Variation with no attribute

guys,

if you created a variation and (yet) no attributes inside, subproducts module will go crazy during product creation. Problems also happen when you dont chose at least one attribute of each variation.

to solve it, it should be added a checker just before some codes.

    if ($variation->attributes) {
...
    }

in subproducts.inc
in subproducts_generate_wizard1, before

      foreach ($variation->attributes as $attribute) {
        $form['settings'][$variation->vid][$attribute->aid]['use'] = array(
          '#type' => 'checkbox',
          '#title' => '',
          '#return_value' => 1,
          '#default_value' => ($defaults && ($defaults[$variation->vid][$attribute->aid]['use'] == 0)) ? 0 : 1
        );
        $form['settings'][$variation->vid][$attribute->aid]['name'] = array(
          '#type' => 'markup',
          '#value' => $attribute->name
        );
        $form['settings'][$variation->vid][$attribute->aid]['surcharge'] = array(
          '#type' => 'markup',
          '#value' => $attribute->surcharge
        );
        $form['settings'][$variation->vid][$attribute->aid]['stock'] = array(
          '#type' => 'textfield',
          '#title' => '',
          '#default_value' => ($defaults && $defaults[$variation->vid][$attribute->aid]['stock']) ? $defaults[$variation->vid][$attribute->aid]['stock'] : 0,
          '#size' => 10,
          '#maxlength' => 10
        );
      }

in subproducts_generate_wizard2, before

      foreach ($variation->attributes as $attribute) {
        // Only include this option in the array if it was selected in the previous screen.
        if ($settings[$variation->vid][$attribute->aid]['use']) {
          $options[$variation->vid][] = $attribute->aid;
        }
      }

in subproducts.module, function subproducts_nodeapi, before

            foreach($variation->attributes as $attribute) {
              if (in_array($attribute->aid, $child_variations)) {
                $options[$attribute->aid] = subproducts_surcharge_extra($attribute);
              }
            }
              $form['variations'][$variation->vid] = array(
                '#type' => 'select',
                '#title' => $variation->name,
                '#default_value' => $node->variations[$variation->vid],
                '#options' => $options,
                '#description' => t('The %name of this product', array('%name' => theme('placeholder', $variation->name)))
              );
            }

and also in subproducts_generate_wizard2 (also in subproducts.inc), it should be deleted

  if(count($options) < count($variations)) {
   return t('Error.  You must select at least one option from each of the variations.');
  }

regards,

massa