Here's the output from drush:


Fatal error: Call to undefined function db_driver() in /home/appa/sites/perusio.net/sites/all/modules/settings_audit_log/settings_audit_log.install on line 10

Call Stack:
    0.0030     119100   1. {main}() /home/appa/drupal/drush/drush.php:0
    0.0650    1419928   2. drush_main() /home/appa/drupal/drush/drush.php:40
    2.0240   21201384   3. drush_dispatch() /home/appa/drupal/drush/drush.php:90
    2.0242   21203576   4. call_user_func_array() /home/appa/drupal/drush/includes/drush.inc:51
    2.0242   21203984   5. drush_command() /home/appa/drupal/drush/includes/drush.inc:0
    2.0246   21204820   6. call_user_func_array() /home/appa/drupal/drush/includes/command.inc:378
    2.0246   21205012   7. drush_invoke() /home/appa/drupal/drush/includes/command.inc:0
    2.0270   21216936   8. call_user_func_array() /home/appa/drupal/drush/includes/command.inc:327
    2.0270   21217352   9. drush_pm_enable() /home/appa/drupal/drush/includes/command.inc:0
    6.2900   22004792  10. drupal_check_module() /home/appa/drupal/drush/commands/pm/pm.drush.inc:381
    6.5129   22037132  11. module_invoke() /home/appa/sites/perusio.net/includes/install.inc:721
    6.5129   22038092  12. call_user_func_array() /home/appa/sites/perusio.net/includes/module.inc:462
    6.5130   22038564  13. settings_audit_log_requirements() /home/appa/sites/perusio.net/includes/module.inc:0
CommentFileSizeAuthor
#5 settings_audit_log-774306.patch775 bytessbuttgereit

Comments

sbuttgereit’s picture

sbuttgereit commented
Assigned: Unassigned » sbuttgereit

In the process of adding the initial PostgreSQL code, I actually started with the D6 way... which of course was wrong :-). So making this work there will be simple. Will have fixed by weekend's end.

sbuttgereit’s picture

sbuttgereit commented

Took a bit longer to get to than I planned, but I have the fix. I want to confirm the process for getting this committed and making sure all checks and balances are in place. My understanding of the process is that I should make the commit, and then set the issue to 'needs review', allow for peer review and once that comes in OK, we can set the issue to fixed.

Let me know if I have some of that backwards.

Cheers,
Steve

asak’s picture

asak commented

Hey Steve - actually you do have some of that backwards ;)

You can have a look here: http://drupal.org/node/156119

The best practice here would be to submit a patch to this thread, before committing it, and only after someone changes it to "RTBC" commit the change.

Seems like a very cool module - i'll be happy to test a patch ;)

that0n3guy’s picture

that0n3guy commented

I'm also up for testing a patch...

sbuttgereit’s picture

sbuttgereit commented
Status: Active » Needs review
StatusFileSize
new settings_audit_log-774306.patch775 bytes

The process documented at the link is certainly a bit more of a traditional approach and I appreciate that it's the Drupal way. But I also want to be sure I'm being consistent with process related to this specific project as well, and sensitive to the management desires of the leader of this project... the last code I reviewed that was under review status here was already committed, thus the question.

Here's the patch very, very simple and I'm already running it on a low volume site and it works fine in my test. Only one line needed changing.

Cheers,
SCB

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

sorry it took so long for me to see this. i've set up the feed now, so hopefully won't take so long next time.

the patch looks great, go ahead and commit.

sbuttgereit’s picture

sbuttgereit commented

Hi--

Tried to commit, but gives me a permission denied message. I was able to checkout the code OK with my CVS account.

Thanks,
Steve

Anonymous’s picture

Anonymous (not verified) commented

doh, my bad. i've fixed the access issues, try now.

sbuttgereit’s picture

sbuttgereit commented

That did the trick. Thanks!

sbuttgereit’s picture

sbuttgereit commented
Status: Reviewed & tested by the community » Fixed

Committed the patch and, assuming I didn't screw up my first Drupal repo commit, this is fixed at this point.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.