Posted by mtk on August 7, 2006 at 6:09pm
Jump to:
| Project: | Drupal core |
| Version: | x.y.z |
| Component: | comment.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi,
in the comment.module file the function:theme_comment_thread_expanded($comment)
has hardcoded:style="margin-left"
so, for instance, every RTL theme would have to override this function.
I think styling should be left outside the code & left for the CSS to handle.
attached the easy solution for overriding the function.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| comment_thread_collapsed.tpl.php.txt | 124 bytes | Ignored: Check issue status. | None | None |
Comments
#1
We try to avoid breaking people's themes during the release cycle, moving to CVS.
#2
for the reasons mentioned in the issue, this is a bug. marking so.
#3
This hard coded CSS no longer exists on HEAD.
#4