Craq submitted a patch to me which resolved some issues he was having with multisite installs. I'm putting it here for wider testing before I commit it... It solves he was issues with repeated image generation....

Comments

marcoBauli’s picture

i just came to report exactly that bug (multiple images generation on multisite)

test the patch and be right back...

marcoBauli’s picture

hmm...applyed the patch manually, but i still get a new replicated cached image every time i reload the page..

repeated images are in the form imagename.jpg, imagename.jpg_0, imagename.jpg_0_0, imagename.jpg_0_1.

I am on Drupal 4.7.2, latest imagecache and imagefield mods.

marcoBauli’s picture

hmm...applyed the patch manually, but i still get a new replicated cached image every time i reload the page..

repeated images are in the form imagename.jpg, imagename.jpg_0, imagename.jpg_0_0, imagename.jpg_0_1.

I am on Drupal 4.7.2, latest imagecache and imagefield mods.

zach harkey’s picture

Same here, every time I call the image it creates a new version _0_14, _0_15, _0_16, etc.

ukdg_phil’s picture

StatusFileSize
new1.76 KB

I've recreated this patch with all the previous changes made - and a couple of minor alterations.

The script was checking if the temp image file existed, instead of the destination. This seems to fix the problem, but please correct me if this check was needed for something else...

If you want to change a script with the 1st patch (top of this issue) already applied - just alter the following line:

if (!is_file($tmpdestination)) {

to

if (!is_file($destination)) {

Otherwise apply this new patch to a clean imagecache - this was created against version 1.9 2006/07/31 of the module.

dopry’s picture

Can you test against imagefield in cvs head? I think this should be resolved now.

dopry’s picture

Status: Needs review » Fixed

this should be fixed in the latest cvs.

ukdg_phil’s picture

Sorry for the delayed response, new version seems to be working ok on multisite installs.

Thanks dopry!

zach harkey’s picture

The fix seems to work but it isn't applied to the latest cvs (unless I'm doing something wrong).

dopry’s picture

It should be applied to cvs. Check your .htaccess file.

Anonymous’s picture

Status: Fixed » Closed (fixed)