Hi

i would warning on a bug when enabling some other modules than locale updater...like this :

Fatal error: Call to undefined function dsm() in C:\wamp\www\xxx\sites\all\modules\l10n_update\l10n_update.module on line 117

i dont know if its important or not..

thanks

CommentFileSizeAuthor
#17 l10n_update.module.patch340 byteswasare
#6 dms.patch304 byteswundo
#5 dms.patch250 byteswundo
#4 l10n_update.module.042610.patch471 bytesdesus

Comments

desus’s picture

desus commented
Priority: Normal » Critical
Issue tags: +translate Localization update l10n_update dsm

When the error occurs, the module does not install.

Fatal error: Call to undefined function dsm() in /home/design/public_html/sites/all/modules/l10n_update/l10n_update.module on line 117

This module is my favorite :(

desus’s picture

desus commented
Assigned: desus » Unassigned
Status: Needs review » Active

l10n_update.module on line 117
_______________________________________________________________________________________________________

/**
105 	* Rebuild project information, update status, etc...
106 	*
107 	* When this callback runs, locale module has already run and update cache is refreshed
108 	*/
109 	function l10n_update_system_modules_submit($form, $form_state) {
110 	//dsm($form);
111 	//dsm($form_state);
112 	// Check we are not on the confirm form
113 	if (!isset($form_state['storage'])) {
114 	module_load_include('project.inc', 'l10n_update');
115 	l10n_update_project_refresh();
116 	}
117 	else dsm("storage");
118 	}

-------------------------------------------------------------------------------------------------------------------------------------

http://drupalcontrib.org/api/function/dsm/6
_______________________________________________________________________________________________________

dsm($input, $name = NULL)

▸ 3 functions call dsm()

devel_execute_form_submit in contributions/devel/devel.module
Process PHP execute form submissions.
messaging_debug_devlog_msg in contributions/messaging/messaging_debug/messaging_debug.module
Message processor, just log incoming messages
vsm in contributions/views/views.module
Debug messages

Code:
contributions/devel/devel.module, line 1655

function dsm($input, $name = NULL) {
  dpm($input, $name);
}

-------------------------------------------------------------------------------------------------------------------------------------

barraponto’s picture

barraponto
he / him
commented

it's a dev branch, i'm not surprised to see a dsm there. but line 117 should read:
else drupal_set_message("storage");
if it works, please post a patch...

desus’s picture

desus commented
Assigned: Unassigned » desus
Status: Active » Needs review
StatusFileSize
new l10n_update.module.042610.patch471 bytes

solved the problem

wundo’s picture

wundo commented
Assigned: Unassigned » wundo
Status: Active » Reviewed & tested by the community
StatusFileSize
new dms.patch250 bytes

There is no need to add that comment line, IMHO we should just remove that line.

See updated patch.

wundo’s picture

wundo commented
StatusFileSize
new dms.patch304 bytes

Cleaning up some other comments too

aiphes’s picture

aiphes
Primary language French
commented

feedback on this issue :

Warning: Got a packet bigger than 'max_allowed_packet' bytes query: INSERT INTO d6bl_watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'php', '%message in %file on line %line.', 'a:4:{s:6:\"%error\";s:12:\"user warning\";s:8:\"%message\";s:3177016:\"Got a packet bigger than 'max_allowed_packet' bytes\nquery: UPDATE d6bl_batch SET token = 'ca13acd130d2264d9773f6d3ee35751d', batch = 'a:10:{s:4:\\"sets\\";a:1:{i:0;a:11:{s:7:\\"sandbox\\";a:0:{}s:7:\\"results\\";a:0:{}s:7:\\"success\\";b:0;s:10:\\"operations\\";a:3:{i:0;a:2:{i:0;s:27:\\"_l10n_update_batch_download\\";i:1;a:1:{i:0;O:8:\\"stdClass\\":17:{s:4:\\"name\\";s:13:\\"image_fupload\\";s:4:\\"info\\";a:10:{s in /homez.342/lyceeler/www/includes/database.mysqli.inc on line 128

is there any link between the the fist issue ?
it's a multisite install, on multidomain hosting on OVH.Each site has is proper DB

tsvenson’s picture

tsvenson commented

Ran into this issue using the current dev. dsm() is still in there.

aiphes’s picture

aiphes
Primary language French
commented

is it a dev version ? where can i find it ? then i could replace the actual version whith this newer ?

EDIT: i've still the issue, and on a single install too..help please

this is the module code:


function l10n_update_system_modules_submit($form, $form_state) {
  //dsm($form);
  //dsm($form_state);
  // Check we are not on the confirm form
  if (!isset($form_state['storage'])) {
    module_load_include('project.inc', 'l10n_update');
    l10n_update_project_refresh();
  }
  //else dsm("storage");
  // by barraponto  drupal.org/node/775194#comment-2887922
  else drupal_set_message("storage");
}
tsvenson’s picture

tsvenson commented

Yes, its the dev version and you can find it on the project page. Its the only one listed.

Just comment out or remove the dsm() as described in the patch in comment #6 and it will work.

aiphes’s picture

aiphes
Primary language French
commented

i've applied the patch, the code is the one i've in the .module file...error still there, i go to flush cache and retry..

aiphes’s picture

aiphes
Primary language French
commented

still there : this is the ultimate warning i got:

Warning: MySQL server has gone away query: INSERT INTO d6pf_watchdog (uid, type, message, variables, severity, link, location, referer, hostname, timestamp) VALUES (1, 'php', '%message in %file on line %line.', 'a:4:{s:6:\"%error\";s:12:\"user warning\";s:8:\"%message\";s:184530:\"MySQL server has gone away\nquery: UPDATE d6pf_sessions SET uid = 1, cache = 0, hostname = '62.160.67.31', session = 'messages|a:1:{s:5:\\"error\\";a:161:{i:0;s:232:\\"user warning: MySQL server has gone away\\nquery: SELECT filename, name, type, status, throttle, schema_version FROM d6pf_system WHERE type = 'module' in /homez.195/provence/www/site/modules/system/system.module on line 752.\\";i:1;s:964:\\"user warning: MySQL server has gone away\\nquery: INSERT INTO d6pf_system (name, info, type, filename, status, throttle, bootstrap) VALUES ('admin_menu&amp in /homez.195/XXXX/www/site/includes/database.mysqli.inc on line 128

i've a shared hosting on OVH .So i cant do anything, and this message come when i do an update.php

tsvenson’s picture

tsvenson commented

Since the warning says "MySQL server has gone away query" it is more a problem with your hosting. Drupal simply can't connect to the MySQL server.

aiphes’s picture

aiphes
Primary language French
commented

ok 2 differents problem so.good to know.hope they arent connected.

aiphes’s picture

aiphes
Primary language French
commented

for #7 , perhaps found the cause , there is a probleme with the commented code on line 237 of 

 * a SELECT COUNT(*) on the temporary table afterwards. db_affected_rows() does

the sign * in () cause a break in the commented block, so i've added another * more,and code seem to be right ..

after second attempt,the module page is displayed,hope its the way to this issue..

j0nathan’s picture

j0nathan commented

Same issues as #0 and #7 (haven't tried any patch yet), subscribing.

wasare’s picture

wasare commented
StatusFileSize
new l10n_update.module.patch340 bytes

Same issue as #0, commenting the line fixed for now.

sutharsan’s picture

sutharsan commented

Applied patch #6 which removes all occurrences of dsm(). Wundo and others thanks for your patches. Please note that module maintainers prefer the "unified" patch format. See http://drupal.org/patch/create at "Patch readability".

sutharsan’s picture

sutharsan commented
Assigned: wundo » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -translate Localization update l10n_update dsm

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +translate Localization update l10n_update dsm

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.