Trying to use csm together with auto_nodetitle module. I configured the auto_nodetitle module to be set based on two tokens provided by CCK fields. However, the CCK field tokens do not get replaced in the node title.

Apparently, the tokens for a node get cached once per request in a static variable (of which the key is based on node id) by the token module. At the time that csm tries to substitute tokens, the node does not seem to contain any CCK fields, so no tokens for CCK are inserted into the cache. At a later stage, when auto_nodetitle does its job, the tokens from the cache are used, so no replacements for CCK field tokens take place.

Comments

jim0203’s picture

jim0203 commented
Assigned: Unassigned » jim0203
Status: Active » Fixed

Thanks for locating this and for posting to the issue queue. I've recreated the bug as you describe it and your description seems more or less accurate. What appears to happen when CSM and Auto Nodetitle are both enabled is:

  • csm_form_alter() calls token_replace() first, when token_replace() only has access to a limited number of tokens (it doesn't have access to those tokens provided by CCK fields, for example).
  • _auto_nodetitle_patternprocessor() calls token_replace() second, and token_replace() still doesn't have access to the tokens provided by the CCK fields.
  • csm_message_alter calls token_replace(). At this point, token_replace() does have access to the CCK field tokens, which is why the substitution in the submit message is performed correctly.

The fix I've put in place involves adding a third condition to the elseif clause on line 68 of csm.module, which prevents token_replace() being run by csm_form_alter(). This fixes the bug and doesn't effect any other functionality of the module.

This will be part of the next dev release which will roll out within the next twelve hours, and will be part of the first beta release of the module.

jim0203’s picture

jim0203 commented
Status: Fixed » Closed (fixed)
cyberwolf’s picture

cyberwolf commented

Wow! Did not expect this one to get ever fixed. Thanks!

jim0203’s picture

jim0203 commented

Neither did I! I've got a really busy year ahead and it's irritating me that I haven't got a 1.0 release of CSM out of the door yet. Two issues to go before a beta release ...

  • Commit d4f1256 on master, 7.x, 7.x-1.x, 6.x-1.x, 2219683 by jim0203: 
    Issue #775374 by Cyberwolf: fixed conflict with auto_nodetitle.module