get errors when I don't enter in image in image field [#77581]

When I upload a flexinode with image fields and they're empty I get an error:

# warning: Attempt to assign property of non-object in C:\apachefriends\xampp\htdocs\searcy\modules\flexinode\field_image.inc on line 47.
# warning: Attempt to assign property of non-object in C:\apachefriends\xampp\htdocs\searcy\modules\flexinode\field_image.inc on line 48.

It looks like empty image fields aren't being handled and it's causing errors. It seems like a bug like this would have been fixed ages ago so I'm wondering if I've done something wrong. I've tried this in 4.7 and CVS.

Comments

Comment #1

mo6

he/him

Dutch

CreditAttribution: mo6 commented 4 September 2006 at 14:43

Version:	4.6.x-1.x-dev	» 4.7.x-1.x-dev
Status:	Active	» Needs review

Lines 47 and 48 in function flexinode_field_image_insert need to have a test, like:

  if (is_object($node->$fieldname)) {
    $node->$fieldname->smallpath = flexinode_field_image_make_smaller($node->$fieldname->filepath, '_sm', $field->options[2]);
    $node->$fieldname->thumbpath = flexinode_field_image_make_smaller($node->$fieldname->filepath, '_th', $field->options[3]);
  }