Actually, the first step to any project_issue tests would be a simple test case that makes sure you can create a project issue node at all. ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 776128-issue_tests-12.patch | 4.27 KB | dmitrig01 |
| #11 | 776128-issue_tests-11.patch | 0 bytes | dmitrig01 |
| #9 | 776128-issue_tests-9.patch | 3.77 KB | dmitrig01 |
| #6 | project_issue-project_issue_test.patch | 2.65 KB | dmitrig01 |
| #6 | project-project_issue_test.patch | 717 bytes | dmitrig01 |
Comments
Comment #1
mikey_p commentedWorks well here, this depends on #774890: Move some setup from PIFT tests for createProject to return a node.
Comment #2
dwwOh, how much I'd love to commit this. Sadly, this is weird to my eyes:
A)
It doesn't say that $project is optional. Just because $edit is optional doesn't mean that if you don't define it, you should clobber the $project the caller passed in and use your own. I think we should probably just remove that
$project = $this->createProject();line entirely and retain the behavior that $project is required for this function. Thoughts?B)
testProjectCreation()needs to be renamed totestProjectIssueCreation()it seems.C) Code comment about "Test project node form fields" is wrong.
Thanks!
-Derek
Comment #3
dwwFixes A-C. mikey_p: do you agree with (A)? If so, set this RTBC and it'll go in. The tests all pass locally with this.
Comment #4
dmitrig01 commentedThis doesn't work. Fixing...
Comment #5
dmitrig01 commentedOk, this works and fixes the issues. I know I shouldn't RTBC my own patch but...
Comment #6
dmitrig01 commentedwhoops... some duplicate code. This is even better (and passes).
Comment #7
dww@dmitrig01: I don't think you cvs up'ed project.test from HEAD, since your project.test patch here isn't needed anymore and conflicts. I'm on BART now. When I get to the conf I'll clean this up and commit. ;)
cheers,
-Derek
Comment #8
dwwCleaned up and reconciled the patches in #6 with what's already in HEAD:
http://drupal.org/cvs?commit=357142
http://drupal.org/cvs?commit=357150
Back to active here, since we really need assertions on the issue metadata fields (Category, Priority, Component, etc).
Thanks y'all, this is so exciting that we're making such great progress!!
Comment #9
dmitrig01 commentedwith metadata assertion
Comment #10
dwwYay, but... ;)
A) assertIssueMetadata() needs a PHPdoc comment
B) the assertions from function testProjectIssueMetadata() could just be merged into testProjectIssueCreation()
C) I can never remember WTF += vs. array_merge() does. Maybe a reminder comment somewhere? ;)
Thanks!
Comment #11
dmitrig01 commentedfixed
Comment #12
dmitrig01 commentedComment #13
dwwCommitted a modified version of this based on some nice in-person debugging here at DCSF (DamZ's Field API talk)...