drush si -y default (or minimal)
WD php: Warning: Parameter 3 to install_configure_form() expected to be a reference, value given in drupal_retrieve_form() (line 581 of [warning]
/var/www/drupal/includes/form.inc).
WD php: Warning: implode(): Invalid arguments passed in form_error() (line 1202 of /var/www/drupal/includes/form.inc). [warning]
WD php: Warning: implode(): Invalid arguments passed in form_error() (line 1202 of /var/www/drupal/includes/form.inc). [warning]
WD php: Warning: implode(): Invalid arguments passed in form_error() (line 1202 of /var/www/drupal/includes/form.inc). [warning]
WD php: Warning: array_merge(): Argument #1 is not an array in install_configure_form_submit() (line 1740 of /var/www/drupal/includes/install.core.inc).[warning]
Parameter 3 to install_configure_form() expected to be a reference, value given in drupal_retrieve_form() (line 581 of [warning]
/var/www/drupal/includes/form.inc).
implode(): Invalid arguments passed in form_error() (line 1202 of /var/www/drupal/includes/form.inc). [warning]
implode(): Invalid arguments passed in form_error() (line 1202 of /var/www/drupal/includes/form.inc). [warning]
implode(): Invalid arguments passed in form_error() (line 1202 of /var/www/drupal/includes/form.inc). [warning]
array_merge(): Argument #1 is not an array in install_configure_form_submit() (line 1740 of /var/www/drupal/includes/install.core.inc). [warning]
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | array_by_ref.patch | 828 bytes | chx |
| #13 | install-cli-form-776178-13.patch | 3.53 KB | David_Rothstein |
| #11 | install-cli-form-756034-v2.patch | 3.38 KB | marvil07 |
| #5 | byref-on-install.patch | 1.05 KB | marvil07 |
Comments
Comment #1
chx commentedPHP 5.3.1 (cli) (built: Feb 2 2010 01:00:04)
drush and core both HEAD.
Comment #2
drewish commentedsubscribing. ran into this today.
Comment #3
chx commented#777138: Strict warning: Only variables should be passed by reference in install_settings_form() (line 849 of /includes/install.core.inc)
Comment #4
chx commentedStill happens. :(
Comment #5
marvil07 commentedI changed the parameters at function definitions to avoid the
&on the non-modified values at two functions.Comment #6
marvil07 commentedComment #7
moshe weitzman commentedNice debugging.
Comment #8
webchickWow. That's esoteric. Nice find!
Committed to HEAD. Thanks!
Comment #9
David_Rothstein commentedNice debugging! But the fix isn't correct - why should $form_state and $install_state have a different behavior? With $form_state the similar bug was fixed in the calling code, and we need to do that here as well. Also, the committed patch doesn't fix install_settings_form() which has the same exact bug...
Please review #756034: install.core.inc make impossible to use cli install because of install_settings_form signature which attempts to fix this in the calling code.
The commit here didn't break anything since $install_state wasn't being modified, but the intention is that it can be modified - again, just like $form_state. I'm not sure it's a rule, but it seems like we always use
&$form_statein all/most form functions for consistency sake (even when we aren't modifying it), so we should probably do the same thing with $install_state. If so, we should roll this patch back once the other issue gets in.Comment #10
David_Rothstein commentedchx also posted #778888: Form functions can't take arguments by reference which is related to this issue.
Comment #11
marvil07 commentedActually, chx suggest me to review where is the exact problem, because like David suggests the real problem is not on install functions, but install is really big ;-)
So, I tried the patch at #3 in #756034: install.core.inc make impossible to use cli install because of install_settings_form signature, and it also solves the problem, and I think in a cleaner way(aka solving the real problem), so I just rerolled the patch to revert my change and apply his change.
Thanks for taking care of this :-)
Comment #13
David_Rothstein commentedLooks good to me - thanks! I think the patch failed to apply because of the line that changed the $Id$ - not sure how that got in there, but here is a reroll that leaves it out.
Comment #14
moshe weitzman commentedyou guys rock.
Comment #15
webchickWow. Great sleuthing, folks!
Committed to HEAD! :D
Comment #16
chx commentedAlmost but the comment has a small problem: you are not passing an object by reference that's quite a pointless exercise they are passed around by handle anyways which is 99.99% of the time is good enough. You pass in an array as in the code.
Comment #17
dries commentedCommitted to CVS HEAD. Thanks.