In views 6.x-2.9, the function signature of views_break_phrase() changed from:
function views_break_phrase($str, $filter = NULL)
to
function views_break_phrase($str, &$filter)
See #329390: Potential PHP 4 bug: Variable missing reference
To cut a long story short, this breaks views integration in flag module, at least for me. The above issue states We might want to scan contrib and see if anyone is using it [with a single argument], but I guess no-one did.
Patch to follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | flag-776242-1.patch | 808 bytes | malclocke |
Comments
Comment #1
malclocke commentedAttached patch follows the example set in views of passing
$thisas the second argument toviews_break_phrase(). Not sure if doing so has any potential negative impact, but it appears to fix the issue for me.Comment #2
tauno commentedMaking the same change in 6.x-2.0-beta2 gets rid of the error for me too.
Comment #3
quicksketchThanks, I'll put this in next time I'm working on Flag.
Comment #4
ordually commentedThanks for posting this! It has fixed the problem for me also.
Comment #5
quicksketchCommitted. Thanks again tauno!
Comment #7
dixon_Was this bug only fixed in 6.x-2.x? It still seems to exists in 6.x-1.x. The patch above works great and fixes the problem in 6.x-1.x too.
Can we apply the patch for 6.x-1.x too?
Comment #8
quicksketchHm, sure enough it doesn't look like this was applied to 1.x. Should apply there too.
Comment #9
mooffie commentedCommitted.
http://drupal.org/cvs?commit=421262
Comment #10
dixon_Wonderful! Thanks!