node revision logging is buggy

here's a patch for the log having its div stripped problem.

attached.

just tested eaton's $node->body with arrays patch, and it doesn't fix any of the revision log bugs, so here's a patch that ensures that if a $node->log is saved, it came from a revision operation, and not just from the node being updated.

new patch with typo in comment attached.

Not tested, but the variable name in the code comment doesn't match. Personally, this looks like a strange fix (a bit of a hack). How come the value is set incorrectly in the first place? Needs more investigation, IMO.

the value is not so much set incorrectly as just carried over from node_load(). backtracking a bit - node_revision_revert is the only code in node.module that sets a value for $node->log:

$node->log = t('Copy of the revision from %date.', array('%date' => theme('placeholder', format_date($node->revision_timestamp))));
$node->taxonomy = array_keys($node->taxonomy);

node_save($node);

problem is, when the node with the revision log is updated, if $node->log on the $node passed in to node _save is not set, then the log message is just carried over, because of this code in node_save:

// We need to ensure that all node fields are filled.
$node_current = node_load($node->nid);
foreach ($node as $field => $data) {
  $node_current->$field = $data;
}

so, my first thought was to patch node_save to make sure it didn't save the log from the old revision if the node being passed in doesn't have a log value.

alternatively, we could:
- ensure that the $node passed in to node_save always has $node->log set, even if its empty
- implement hook_load or hook_nodeapi in node.module to handle the unsetting $node->log

suggestions as to which way to go?