In PostgreSQL you must use apostrophes for string literals not quotes.

The attached patch changes the quotes to apostrophes in queries.

I filed this bug as critical because PostgreSQL is one of the two supported core Databases and without this patch Patterns is unusable on PostgreSQL.

Comments

bpeter’s picture

StatusFileSize
new4.41 KB
apotek’s picture

Category: bug » feature

Thanks for the patch! Just changing this to a feature request, since this isn't a fix for something broken in existing functionality, but an extension of existing functionality.

thanks again.

apotek’s picture

quick scan of this patch looks good. do the devs have a suite of tests you can run?

vaish’s picture

Status: Needs review » Fixed

Patch committed. Thanks arywyr. Could you please confirm if your patch also fixes the following issue: #390972: wont work on PGSQL?

@klktrk : We usually run XML and YAML example patterns bundled with the module as a test. Definitely not ideal but so far proved to be working quite well. This obviously wouldn't cover testing all the functionality module provides like patterns server or editing of patterns but covers testing all the components which is area that needs most testing.

Status: Fixed » Closed (fixed)
Issue tags: -PostgreSQL

Automatically closed -- issue fixed for 2 weeks with no activity.