$from not set [#77689]

I don't see in the cvs version where the line mentioned here: http://drupal.org/node/69336 at 363 was included. Can somebody confirm that the $from information is being set properly (it doesn't look like it to me, but I could be wrong). This appears to only be an issue with respect to the advuser_multiple_email_confirm_submit() function.

Comments

Comment #1

Mojah CreditAttribution: Mojah commented 27 August 2006 at 14:16

Hi,

I cheked up on the from information, and it looks like its being set correctly.

Can you specifiy what problem you are having?

Thanks.

Comment #2

drupal777 CreditAttribution: drupal777 commented 27 August 2006 at 23:32

The line in question is intended to set the $from information. Yes, the system provides a default, but it is not appropriate to have the from information be the default when the real from information is available and can be used, if only it were set. Are you saying that you have tried it without that line and the information that is set is the same as it would be if that line were included?

Comment #3

Mojah CreditAttribution: Mojah commented 28 August 2006 at 11:50

Hiya Drupal777,

I just did a test and received an email with the correct from info. Its the same code in the user.module that I referred to for the $from info.

btw. I don't think you would want to use this module for emailing large number of users. The module appears to call a function within the loop, which I read somewhere is not the ideal thing to do...especially when going through 100s of records.

The client has used it safely to send messages to 50-100 users.

Comment #4

dsgn30kw CreditAttribution: dsgn30kw commented 30 August 2006 at 10:33

Hi Mojah,

I tried with the latest cvs release but couldn't get the from to work. It shows unknown sender when I tried a few test messages. Btw, I am using your module to filter profile fields so that I can email specific users but as you mentioned it's not advisable to use it for mass emails, what do you recommend? Thanks.

Comment #5

freeman-1 CreditAttribution: freeman-1 commented 21 September 2006 at 17:48

I faced the same problem.

Here's what solved it for me, I added a line to set $from near line#326 :

...
function advuser_multiple_email_confirm_submit($form_id, $edit) {
  if ($edit['confirm']) {
    // [Manual:20060922] w/o this, the $from is empty !
    $from = variable_get("site_mail", ini_get("sendmail_from"));

    foreach ($edit['users'] as $uid => $value) {
      $account = user_load(array('uid'=>$uid));
...

Comment #6

mcurry CreditAttribution: mcurry commented 17 January 2007 at 09:01

Assigned:	Unassigned	» mcurry
Status:	Active	» Fixed

Fix committed in HEAD. Packages are being built, even though timestamp shows otherwise. Please see: http://drupal.org/node/108493 for background. If you download the HEAD package at least 24 hours after the latest commit, the changes should be there.