When loading a node I have a custom bit of code that creates a parallel stucture based on clipper and the node types. Anyways, this is difficult with the usage of nodeapi load used by clipper.

The attached patch changes clipper load to modify the node directly. This used with a weight allow you to have your module run after clipper and see the clipper structure during load.

I don't know if this is a big enough feature to everyone that uses clipper to justify inclusion but it shouldn't change any functionality and provide some new flexibility.

CommentFileSizeAuthor
clipper_load.patch.txt770 bytesneclimdul

Comments

Bèr Kessels’s picture

This looks like a very nice improvement. Can anyone please test this?

neclimdul’s picture

Well, no one else has reviewed this but I can attest to this solving the problem on a site I use and its been working live for several months now. I don't like marking my own patches RTBC especially without review but so I won't but it is a solid patch.

Bèr Kessels’s picture

I am not sure how to deal with this.

First: Drupal 5 has got this feature in core: modules need to add stuff to a node structure, rather then to the body.
second: We are still working on big improvments to clipper, most of them to allow views integration (w00t). This feature is already implemented in these changes, meaning: we load clipper info earlier on in the proces.

But third: I doubt any of these changes will make it into a 4.7 release. So I don't really know how to deal with this.

Moreover: I am short on time. I welcome anyoen who makes improvements, because that is Great[tm] for all of us. However, this feature needs some testing and mabe then some tweaking. I don't have the time to test this thoroughly, and I hope you understand me when I am a bit reluctant to just commit this.

Do you know anyone else whom is developign for clipper, who could test this patch?

Bèr Kessels’s picture

Status: Needs review » Fixed

Added and committed. Thanks.

neclimdul’s picture

Thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)