if you end up in project_issue_query_result() with the $query object being NULL, you hit some completely bogus code. normally, this never happens, since project_issue_query_parse() always adds something to the query if it would otherwise be empty (the default issue states).

however, the fix for http://drupal.org/node/57023 changed project_issue_query_parse() in a way that left $query NULL. this exposed the bug with the dead SQL query i'm talking about here. regardless of what happens in #57023, project_issue_query_result() should be organized such that we *know* $query always has something, and we should rip out dead code that's never being hit.

stay tuned, patch forthcoming.

CommentFileSizeAuthor
#1 project_issue-no_bogus_query.patch3.11 KBdww

Comments

dww’s picture

Status: Active » Needs review
StatusFileSize
new3.11 KB
halkeye’s picture

Status: Needs review » Reviewed & tested by the community

reviewed

RTBC

dww’s picture

Status: Reviewed & tested by the community » Fixed

applied to head, 4.7 and (gasp) 4.6. ;)

Anonymous’s picture

Status: Fixed » Closed (fixed)