Download & Extend
Taxonomy Ticker » Issues

Causes a "Done, but with error on Page" at the bottom of browsers.

Posted by jake28 on August 9, 2006 at 3:36am
Project:Taxonomy Ticker
Version:4.7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

It does this on every page, not just pages with the ticker. I've posted a $200 bounty on this, along with a couple of other things, so hopefully that leads somewhere. I also mentioned that I really need the ticker to scroll horizontally, too.

Login or register to post comments

Comments

#1

Posted by george@dynapres.nl on August 9, 2006 at 11:28am

The message usually indicates some faulty javascript. Do you have an example of a page with the errors?

#2

Posted by jake28 on August 9, 2006 at 10:41pm

I had to disable the module. It was causing other strange problems with css layout. I don't mind enabling it again if you contact me, but I'd prefer to link the page privately.

#3

Posted by george@dynapres.nl on August 10, 2006 at 8:28pm

The module includes the javascript code twice:

<?php
function taxonomy_ticker_init() {
  theme_add_style("modules/taxonomy_ticker/taxonomy_ticker.css");
  drupal_set_html_head('<script language="JavaScript" src="/modules/taxonomy_ticker/taxonomy_ticker.js" type="text/javascript"></script>');
  drupal_add_js('modules/taxonomy_ticker/taxonomy_ticker.js');
}
?>

Try to change this to:

<?php
function taxonomy_ticker_init() {
  theme_add_style("modules/taxonomy_ticker/taxonomy_ticker.css");
  drupal_add_js('modules/taxonomy_ticker/taxonomy_ticker.js');
}
?>

#4

Posted by jake28 on August 10, 2006 at 11:49pm

Much appreciated! You fixed it entirely. And I don't know how long I've been staring at that code...

On a side note, I'm learning javascript and should have the scrollLeft code pretty soon. I'll post back when I figure it out.

Issue closed. gjmjr has fixed the bug.

#5

Posted by george@dynapres.nl on August 11, 2006 at 11:20am

As a bonus, I'd suggest to move the lines from taxonomy_ticker_init() to the beginning of taxonomy_ticker_contents() and to remove the first function. This way only pages which actually use the block will include the css en javascript. This reduces any conflicts in the future.

What's that with the $200 bonus? ;)

#6

Posted by mathieu on August 11, 2006 at 2:46pm

Commited to 4.7 and HEAD. Thanks! I'll test your suggestion about moving code to _contents() and commit this next week.

#7

Posted by mathieu on August 11, 2006 at 2:49pm
Status:active» fixed

..if it's fixed, it's fixed. :)

#8

Posted by Anonymous on August 25, 2006 at 3:02pm
Status:fixed» closed (fixed)

#9

Posted by akhillesh bandaru on May 14, 2008 at 2:43am

i too experience this problem tell me a solution
line:1
char:1
error:object expected
code:o
url:http://www.employment.tn.gov.in/pgt2008/LIST%20OF%20NOMINATION%20FOR%20MATHEMATICS.pdf

#10

Posted by parvezhre on October 11, 2008 at 6:58am

how do i correct the error 'done, but with errors on page, i am tired of this. please assist
regards. if possible let me know the procedure to do it.

#11

Posted by brisbanett on September 19, 2009 at 1:54pm

can someone point me to a page that lists a variety of ways to stop this happening. Or explain why it happens.

Ive got the same problem.

If you would like to see how it occurs on my page visit - www.tabletennispost.com

please help I don't know how to programme