Create revisions not forced

you realy need to be more detailed...

No revision is created at all or is the new revision "live" automatcally?
What does the history show you?
what does the revision table show you?

Well this is all related to the revisioning of drupal. In normal cases this is forced you can see it that the checkbox on the node-type form and in the node form which tells you "create a new revision" is not uncheckable ( and checked ).

This should force every save to be a new revision. This works for me in the non-draft mode, so there must be a sideeffect.

Can you tell me if that checkbox is checked and visible for you (during editing the node)?

This may be related or not: For my client I am using the draft support, say there is no forcing on publishing, but still new revision is forced on any edits. There's a group (role) A which may create and edit content (but not publish it) and a group B which may (un)publish content. Since group A is responsible for content they are also able to view revisions. Therefore they also see the fieldset "revision information" on node edit forms (it only displays the revision message/log box, but not the "create new revision" checkbox as group A does not have administer node persmissions).

My client doesn't want group A to see this fieldset though, so at first I just unset $form['revision_information']. This caused the exact same error as described by you, now there weren't any new revision created as with unsetting the fieldset the hidden checkbox "create new revision" and its value was lost also.

Well unsetting the form element is not the right way to do it, use #type=hidden in you case.

While i undestand that in sin.stars case the revisions are not created, iam not sure what happens in shp case.

Well actually this is not the expected behavior. New revision should be forced in all cases, if moderation is switched on. Need to be fixed.

To your ideas.: Well write a proposal but really try to find people helping to implement it, before you spent to much time planning. For me, iam here actually to maintain content moderation, so i will spend all time i have left from client work with bugfixes rather then any new features.

fixed, checking the "Create new revision" checkbox is forced when you select to moderate a node type

released in in 1.4

Hi,

I had a problem with this - i had existing content types, only one of which i wished to add moderation to.

I installed the module, then edited a content type. When i saved, i got the error "If you chose to moderate this content type, you must switch "Create new revision" in the workflow tab on" even though i didn't choose to moderate that particular type. - i.e. it forced me to enable revisions.

I removed the helper function

/*
 * Helper to ensure, that Create new revision is always checked, when a node type is selected to be moderated
 */
function _content_moderation_validate_node_type_form($from,&$form_state) {
  if($form_state['values']['node_options']['node_content_moderation'] == 'node_content_moderation' && $form_state['values']['node_options']['revision'] === 0) {
    form_set_error('node_options',t('If you chose to moderate this content type, you must switch "Create new revision" in the workflow tab on'));
  }
}

to "fix" the problem - i don't know what the above should be, but i'm guessing there's something odd going on!

Hmm, to be seriuos, i have completely no idea why it fails.

Could you please try a === here

  if($form_state['values']['node_options']['node_content_moderation'] === 'node_content_moderation' && $form_state['values']['node_options']['revision'] === 0) {

and try again?

If that still does not work out, could you dsm $form_state['values']['node_options']['node_content_moderation'] when you save and not activate it?

Thanks for the feedback!

fixed, it was the issue stated above