Setting Editablefields to Focus ruins UX

janvandiepen added it, but - I am not at all sure I understand why?

http://drupalcode.org/viewvc/drupal/contributions/modules/editablefields...

I wonder if it was there for testing purposes initially?

Maybe we should simply remove it altogether?

Hopefully Jan can comment...

Cheers
Mark.

To be honest, I hadn't even noticed it and it was certainly not done on purpose.
The 3 lines of code were put there to replace some code (also used for focusing) in Drupal.editablefields.init and Drupal.editablefields.load.

See: http://drupalcode.org/viewvc/drupal/contributions/modules/editablefields...

The focusing was originally added to solve issue #556194: Fields not showing if value doesn't exist. by giving an empty field focus after clicking its label.
If removing the 3 lines of code will not break the intended focusing/blurring behavior of the fields, then please go ahead and remove it permanently.

Appreciate the feedback though. So thanks for that mikestefff.

Mikestefff, can you give this a good test and report back?

Cheers

Mark.

I dont know ! - Jan?

Sorry for not responding earlier.

We need the focusing (and blurring) behavior for the implementation of collapsing fields. The label was made click-able to allow focus to be set to an empty (invisible) field that goes with it.

The original code that was used to do the focusing was removed from Drupal.editablefields.html_init() and Drupal.editablefields.load() and replaced by some code in Drupal.behaviors.editablefields() in editablefields.js. Drupal.behaviors is a funny thing. In our case it should attach (but not execute) the focusing behavior to the editablefields on initialisation. Somehow it also executes that behavior on a page when opening it, hence the displacement.

What should be tested is if the patch that removes the initial displacement does not change the intended behavior of focusing and blurring needed for collapsing the fields. So run some tests with and without the patch and see if the behavior, with the exception of the initial displacement, has not been changed.

+1 was about to post issue. thanks for patch!

I'd like to see this patch get committed or the lines removed, either way. What can I do to help the process along?

I'm changing the category from feature request to bug report, since this seems like an actual problem with existing functionality, not a request to improve existing functionality. Please change it back if I'm wrong in this assumption.

My use case makes this "bug" rather egregious. I'm only using click to edit formatters, so the focus gets passed beyond the editable fields to the next form field on the page (which is actually half-way down the page from the editable fields), totally confusing users.

I'd really like to see this patch make it in. Or I could roll a new one that simply removes the lines in question, if that method is preferred.

What needs to be tested to ensure that this doesn't break things?

works for me too!

Is there any likelyhood of this patch being released as a new version of editablefields please?

I've just hit the same problem, and the patch works for me also. But I am not confortable with the concept of live sites running for long periods with patched code, in case a later release comes along that doesn't include the patch.

Thanks

I cloned branch 6.2.x: http://drupal.org/node/165016/git-instructions/6.x-2.x

I downloaded the patch and applied it, but I got this error msg:

$ git apply -v editablefields-removeFocus.patch
Checking patch editablefieldsNew.js...
error: editablefieldsNew.js: No such file or directory

Help me Obi Wan. You're my only hope.

OK, I found the lines that needed to be commented out in editablefields.js, and just did so manually. Although, it's my understanding that the patch needs to apply properly in order to be committed. True?

OK, this thing works! Thank you. Bringing the focus down to the bottom of the page was driving me batsh*t crazy.

Now... what's a guy gotta do to get a patch committed around here?

From what I see above it's been tested numerous times, and there's no reason the code that is commented out can't be taken out completely....?

I assume that changing the status to "reviewed & tested by the community" is all we need to do at this point. Now we just wait for the maintainers to get through their backlog of patches. At least that's what I gather from here http://drupal.org/node/332678 .

If someone knows of something else we need to do, please post.

Hi,

Thanks for testing and for the patch itself and sorry for such a late commit.

I've removed the lines where we were focusing and also gave credit to mikestefff.

Thanks,
Andrei