Show the form element description for tagging

You mean the button description?

ah yes, i remember we removed the description. If you are interested, add a feature request for it (and implement it :) )

Well i guess then you are up to convince someone to help you :)

ah yes, i remember we removed the description. If you are interested, add a feature request for it (and implement it :) )

I think he wants the "Help text", which is a field on the vocabulary's edit page ("Instructions to present to the user when selecting terms...")

Just out of curiosity, why would this have been removed by the module? The help text is rather helpful, but if someone doesn't want it displayed, they can simply enter nothing into this field and it won't be displayed (making it user configurable, rather than overriding it and making the choice for the user). Maybe we're talking about two different things. Did you really mean "description", which is actually another field on the vocab's edit page. Sorry, I just started using this module so I'm not sure what features it had before when compared to now.

In any case, if you meant the help text, and not the description, and you say that it was removed from the module, it seems like we'd be reinventing the wheel if we wanted to have it put back into the module (since it was there before?)... so can you simply put it back and let the users decide (by filling out the help text field on the vocab edit page) if they want to display help text?

Again, sorry if we're talking about two different things. I came here searching through the issues to see if someone else reported that the help text isn't printing to the node edit page under the vocab(s) controlled by this module and this was the closest issue I found. I'll open a different issue if necessary. Let me know.

Thanks!

Iam totally fine if someone implements showing those descriptions, so no need to discuss it even. Iam right now just limitted in my time and try to concentrait on the maintainance, so bug-fixing only.

Iam totally fine if someone implements showing those descriptions, so no need to discuss it even. Iam right now just limitted in my time and try to concentrait on the maintainance, so bug-fixing only.

I totally understand.

Was the vocabulary "help text" part of the module before? Did it ever display the help text on a node edit form under the Tagging field portion of the form?

If yes, can you attach an old copy of the module here so that the code can be added back? Like I said, if the code was there at one point in the past, re-writing it seems like a waste if we can just get an older version, grab the code, and drop it into the new version. ;-)

Use the CVS access and the Tags to get the version you need :)

According to the notes for version 6.x-2.0-beta2, the vocabulary help text was added to the module (an issue was submitted and 6.x-2.0-beta2 resolved the issue).

I don't actually see major differences in the two tagging.module files (using FileMerge to view the differences on a Mac), other than these...

This was added:

// Thats the way we use the API. Some simple short lines.
if(module_exists('extractor')) {
  $terms = extractor_extract($node->body);

  $result = array();
  foreach($terms as $key => $term) {
    $result[] = array('#weight' => (1/$key), '#name' => $term);
  }
  $suggestions = $result;
}

This was changed:
from...
$element['#description'] = ""; // t("Type and press enter to add the tag"); (6.x-2.0-beta2)
to...
$element['#description'] = t("Type and press enter to add the tag"); (6.x-2.1)

And this...
from...
$element['#field_suffix'] = theme('tagging_widget_button', $vid).$old_input.'</div><span class="tagging-vocab-descr">'.$element['#description'].'</span>'; (6.x-2.0-beta2)
to...
$element['#field_suffix'] = theme('tagging_widget_button', $vid).$old_input.'</div>'; (6.x-2.1)

I thought it was that last part, so I replaced $element['#field_suffix'] = theme('tagging_widget_button', $vid).$old_input.'</div><span class="tagging-vocab-descr">'.$element['#description'].'</span>'; with $element['#field_suffix'] = theme('tagging_widget_button', $vid).$old_input.'</div>'; and tested, but there was no change. I guess I just don't understand what controls the help text being displayed. Can you shed some light on this?

Thanks!

It's a rather good module. The only thing it's missing is the display of the help text, which the developer says he removed (I assume he meant intentionally), but I cannot understand why because it was added in a version of the module prior to that. Also, there's no real reason why the help text should be omitted because if a user doesn't want the help text display he/she can simply not put anything into the help text field on the vocabulary's configuration page.

I've tried the best I can to figure it out, but my module-coding skills just aren't at that level and my PHP knowledge is just enough to get things done when I need to tackle a specific, not-too-difficult task. I tried editing the module a little but it didn't produce the results I was hoping for.m :(

@11: I have no futher comments on this.

if you think, you can _expect_ someone to behave lon behalf of your wishes, you maybe must be:
- The King
- Paying him money
- Being a wonderful person convincing him

Iam really suprised by your reaction to my clear statement. All i was going to say is, that iam not going to implement that feature due to time reasons. I use my time to fix bugs, so people can seemlessly use this module. I could also have not commented on it and let you wait for a gazillion years.

@12: Just wait a bit, maybe i find some time to dig in and give you the hints you probably need. Thanks for your effort.

@13: Sounds good. I can wait. It's not a critical bug and I'm happy to try to do it myself if you have time in the coming weeks to give me a hint. :-)

@14: iam pretty sure we undestood eachother. Its just a matter of time, i hope (on my side) it is not a matter of competence.

What i was just trying is to tell you, that i most probably wont find the time to implement it. This should help you not just "wait until its" done - so if you rely on it, you might wait forever. Its just a clear statement that this feature / contribution is valid and needed, but i dont have time to implement it. "please help you you need it".

I call for contributions and teamwork. Thats my statement.

And iam totally eager to help and collaborate - but be patient.

So if i might step on your shoes - excuse me.

will be included in 2.2

released in 2.2

Excellent! Thanks for the update.
I'm away on vacation right now but I'll test it out this weekend and report any bugs.

Thanks again!

Updated the module and it looks great. Thank you very much!