Synchronization of Roles/Groups only work from phpBB3 -> Drupal

Hello everyone,
I guess I found the error.

In the section where users are added to the groups it was checked, if the groups are empty and only if thats the case, the group was added. Of course there ARE groups, so that if-clause was misleading.

Furthermore when I created a user, the initial Drupal roles were NOT synched, when the user was created. I added a check, if the user is new (in phpBB), and if, the groups are added with the first synch. The variable is called $is_new_user

Also I found out, that one foreach-loop was not always getting an array as argument, thus throwing errors. I also fixed that.

Please see the attached patch. Now if DRUPAL is set as master, the phpBBgroups are added (or removed) correctly as soon as the user account is edited in DRUPAL. Also initial Drupal roles are synched to phpBB and the users are put into the regarding groups.

I have not tested, if the patch destroys anything when phpBB is set as master system, so please test it before use.

--> I also noticed, if Roles are deleted from DRUPAL, the users stay within the phpBB group. One has to either first remove the role to be deleted from all users (thus they are correctly thrown out of the group) and THEN delete the role itself. Or one has to remove the users from the phpBB group directly within the forum.
I dont know if that's working as intended, but will not investigate that further.

Comments / questions / etc are welcomed.
Best regards
Sera

PS: That's my first patch. So I don't know if I did everything correct.
PPS: I forgot to change: line 1677 from
if (!isset($new_roles[$rid])) {
to
if (isset($new_roles[$rid])) {

DON'T USE THE ATTACHED PATCH. Please see patch in #2!

Please use this attached patch instead of the previous one (but still test it first). Somehow I can not delete the previous one from my post.

The bugfix herein fixes the bug, that as soon as a user is added, all roles which he hadn't initially were set, and all which he had, were unset. Now it should work correctly again: a user which had the role X, still has the role X after he was added to phpBB Forum via sync.

Okay, I noticed that somehow the query which master was set, wasn't done correctly (or partly ignored). At some places it was set manually (not by me...).

I fixed that, so I am always calling the _phpforum_set_user_data function with $sync = PHPBB_SYNC_TO_MASTER (which can be both), when I am outside the function. Inside it makes the query and depending on which variable was set by the user within the configuration of the phpbbforum module, it calls itself with $sync = $syncto (which is then either the option that phpbb is the master, or drupal is the master).

For debugging options I inserted some more brackets at if-clauses, and some more comments, to which the brackets belong. [The loops and complex if clauses are really very tricky...]

So now it syncs correctly, and ignores changes from the slaves. It only syncs changes from the master system.

Please test this before you are using this at a live site!

Patch is attached.

PS: Please note that the uid =1 isn't synced. This seems to be intended! So that the super admin in drupal can be another person than the super admin in phpbb.

Due to the new release from 24th november, I have to test how far (or not) the release candidate has included the fixes. Somehow I can't find any notes about that.
If it's not included, I will try to port the patch and have a look to the removal issues. Thank you for pointing that out.
Best regards
Sera

Hello everyone,

as the initial problem still exists with the new release of this module, I ported the patch to version 6.x-2.0-rc1 (only the number of the lines, where code-fixes were made, changed). (I hope I created the patch file correctly, somehow I always mix the commands for creating a patch file up...)

@snailian: I can't re-create this problem. Right now I have a group called "Project members" in phpBB, and a corresponding role called "Project member". When I add this role in Drupal to a person, he/she appears correctly in the "Project members" group in phpBB. When I remove the role in Drupal, he/she disappears in the "Project members" group in phpBB.

Did you configure the phpbbforum Module correctly to sync the role with the group? Which php Version do you use? And from which user do you wanted to remove a group? It does not work for the administrator account though (uid=1, this is inteded, I guess).

I need to have more information here. Nevertheless I will try to add/remove several roles/groups at the same time and do some more testing. [Edit: works with 3 groups without a problem.]

@Snet89: What exactly do you want to synch? From Drupal to phpBB? Or vice versa? If Drupal is the master, the changes you made in the groups in phpBB are only temporary and will be overwritten as soon as the next sync process started. You need to change the Drupal roles, if you want to move a person from one group into another (if Drupal is the master).
I need also more information here.
-----------------------------------

Feedback to the patch is still welcome and more review is needed.
vb, I dont know if you read this, if you need more information from my side to include this into an official release, please don't hesitate to ask. I am still new into such deep bugfixing.

Best regards
Sera

Hello vb,

I tested now RC2 (Drupal is set to be the Master).
For existing users:
* roles added are synced correctly (one or more at the same time)
* roles deleted are synced correctly (one ore more at the same time)

Adding AND deleting roles (e.g. add two roles, take one existing away) at the same time does not work though.

When adding (or removing) a user to (or from) a group in the phpBB forum the user will get (or loose) the regarding right in Drupal also (while Drupal is still configured to be the Master). I think this is still a glitch.

When configuring Drupal to be the master, I would expect Drupal to ignore changes made within the phpBB forum.

Examples:
Setup:
Master: Drupal
Role 1 synced to Group 1
Role 2 synced to Group 2

Example 1 (correct):
User: has no roles yet
Drupal: User receives Role 1
phpBB Forum: Role 1 is synced, User is added to Group 1

Example 2 (this is how it should work)
User: Role 1
phpBB Forum: User is added to Group 2
Drupal: There is no resync, thus the User does NOT receive Role 2! With the next sync (Drupal -> phpBB) the user should be removed from group 2 again!

Example 3 (this is how it should work)
User: Role 1
phpBBForum: User is removed from Group 1
Drupal: There is no resync. The user should not loose Role 1. With the next sync (Drupal -> phpBB) the user should be added into group 1 again.

Example 4 (status quo right now)
User: Role 1
phpBB Forum: User is added to Group 2
Drupal: Resync. User gets Role 2!

Example 5 (status quo right now)
User: Role 2
phpBB Forum: User is removed from Group 2
Drupal: resync: User looses Role 2, while it was set within Drupal before