The current hook_nodeapi doesn't allow for the mailing list address field to be updated, meaning if an admin wants to add/change the mailing list address for the group after it's been created (and the "insert" op) has fired, the change is ignored. This patch resolves that.

CommentFileSizeAuthor
og2list_nodeapi_update.patch1.04 KBjoshk

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented

This is actually intended behaviour, i think that changing the mail address would be highly confusing. I am open for discussion though.

joshk’s picture

joshk commented

Mainly this comes up for me when I forget to assign a mailing address at the outset, but I can see other instances where it might be necessary to change the address.

Perhaps by default the mailing info can be in a collapsed fieldset so as to discourage people from doing it unless they "really mean it?"

Alternatively, if the field is to be ignored, it should disappear from the form. However, I think changing the address should be a possibility, if not one often used.

ajwwong’s picture

ajwwong commented

Thanks everyone for your hard work here! It's looking great, so far. :-)

Anyhow, I support this idea, especially for people who have preexisting groups, which they would like to initiate a mailing list for.

See, I've got a couple of old groups, which I "hand-ported" over to a new group, just so they could have the og2list functionality, and it actually took me a while to do that [maybe there's a faster way than I did]... but anyhow I think a patch like this would probably save some people some time... just my 2c :-)

gerhard killesreiter’s picture

gerhard killesreiter commented
Status: Needs review » Fixed

committed to cvs.

Amazon’s picture

Amazon commented
Status: Fixed » Closed (fixed)

This is going to cause confusion for groups that change their list address. But moving to closed anyways.