Hi.
I needed the "Immediate Login" Feature to work without the User setting a password. The User should be logged in right after registration, but should not be able to log in again without verifying the E-Mail -> get the automatic set password from the mail or use the link.

As this was stated in the Text on the modules config page:
"Immediate login
If set, the user will be logged in immediately after registering. Note this only applies if the 'Set password' option above is enabled."

I tried to find a way arround this and changed Line 388 from
if($reg_pass_set && variable_get('logintoboggan_immediate_login_on_register', TRUE)) {

to
if(variable_get('logintoboggan_immediate_login_on_register', TRUE)) {

I think this could be there for default so one can decide what he needs. Maybe the text could say that it is recommended to check the "Set Password" also when using "immediate Login", but it should not be necessary as this is a use case.

Thanks for this module.
JTHan

CommentFileSizeAuthor
#17 README.txt2.27 KBdoublejosh
#16 registration_toboggan.zip2.04 KBdoublejosh
#15 registration_toboggan.zip2.01 KBdoublejosh

Comments

hunmonk’s picture

hunmonk commented
Version: 6.x-1.6 » 7.x-1.x-dev

i think there's a chance this simple change would break other stuff -- there's a lot tied together in the module around this functionality.

in any case, it would be a fundamental change in the workflow of the module, which i'm not willing to do in the stable branch. will consider for future releases.

benone’s picture

benone commented

subscribe

Are you going to add this feature to 6.x ?

hunmonk’s picture

hunmonk commented

Are you going to add this feature to 6.x ?

new features are closed for 6.x, so, no.

hunmonk’s picture

hunmonk commented

please see http://drupal.org/project/logintoboggan#commitment for more information on how task/feature requests are handled in the module

doublejosh’s picture

doublejosh commented

I love this registration workflow concept too!

Seems like a small enough patch can pull it off, so am also interested in testing and getting it ready for the next round of features... does that mean D7?

hunmonk’s picture

hunmonk commented

LT currently does nothing to prevent a user from logging in. as such this would be a pretty big workflow change, and i'm not so sure it's useful to enough people to warrant inclusion in the module.

feel free to submit a patch, but i can't promise you it will make it into the module... ;)

doublejosh’s picture

doublejosh commented

Same kinda thing: http://drupal.org/node/582764#comment-4021322

Patch forthcoming.

steveparks’s picture

steveparks commented
Status: Active » Postponed (maintainer needs more info)

Hi doublejosh,

Is this still something you're interested in submitting a patch for? If so, we'd be happy to review it (with no guarantees).

If not, can the ticket now be closed?

Thanks very much
Steve

benone’s picture

benone commented

yes, I'm still very interested in that feature. THX

steveparks’s picture

steveparks commented
Status: Postponed (maintainer needs more info) » Needs work

Hi benone,

Ok, we'll leave this ticket open for a while and be ready to review your patch.

Thanks
Steve

mrfelton’s picture

mrfelton commented

Also very interested in this feature.

anglo’s picture

anglo commented

I am using 7.x-1.2.
Interested in the option to hide the password field and to auto generate the password.

shrthnd’s picture

shrthnd commented

You would have to seriously consider security before implementing this, but I think it possible with a little css and javascript.

doublejosh’s picture

doublejosh commented

This is absolutely a security gray area as a trade-off from ease of participation.
The type of site/account/personal-content needs to be appropriate.
Also the permissions associated with this role of user also must be super low pre-verification. Perhaps still having to use captchas to post if at all, etc.

Guess I lied about a forthcoming patch. I do have a code branch if anyone wants to compare notes?

doublejosh’s picture

doublejosh commented
StatusFileSize
new registration_toboggan.zip2.01 KB

Went ahead and whipped this up. Took the form of a submodule, or separate module.
Happy to set that up, but figured I should post here first (this is D6).

doublejosh’s picture

doublejosh commented
StatusFileSize
new registration_toboggan.zip2.04 KB

Here's a D7 version.

doublejosh’s picture

doublejosh commented
StatusFileSize
new README.txt2.27 KB

Worked up a security README to go along with it.

iamEAP’s picture

iamEAP commented

Marking as needs review. Would be great to see this as a sub-module, or if that's not appropriate, a separate contrib module with notes/links thereto from the LoginToboggan project page.

iamEAP’s picture

iamEAP commented
Status: Needs work » Needs review

Suppose it would have been great to mark it for review... Whoops.

doublejosh’s picture

doublejosh commented
Issue tags: +password, +registration flow

Just a ping.

Wondering if I should make a module? Going to assume this won't making it into Logintoboggan ;)

doublejosh’s picture

doublejosh commented

Went ahead and created a module for this (Been using a custom maintained solution for a long time).
http://drupal.org/project/registration_toboggan
Would be great to have it as a sub-module here though.

JThan’s picture

JThan commented

Disclaimer: This comment is not helpfull at all

Nice to see what came out of my little initial need (well, the customers need). This is what I love about the diverse Drupal Community. Keep up the good work and Thanks to everyone.

deggertsen’s picture

deggertsen commented
Status: Needs review » Closed (won't fix)

Generate Password takes care of this issue. Or the module referenced in #21. I'm closing this issue seeing that those take care of the problem here.

It might be nice to have this functionality rolled into LoginToboggan, so if that's going to happen this issue could probably be reopened.