cmcintosh [cmcintosh]

I would suggest taking a look at http://drupal.org/coding-standards as well as running your modules code through http://drupal.org/project/coder - it's important to have a unified coding style for others to be able to easily contribute to your project with eg. patches.

Some changes you should do are to indent with double spaces and not end your php-files with a ?>

The module seems like a good idea though - I would be happy to help you with feedback on it.

+1

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

+1 ...awesome!

voxpelli is correct about the coding style, this definitely needs to get fixed up.

Some other comments

- If all you are doing is checking user_access(), you don't actually need a separate access callback. You can just put the perm into the 'access arguments' key. See the comments service in the main services download for an example of this.

- You may also want to put your functions into an include file using the 'file' key. Again, there are many examples of this in the existing service implementations.

The coding style stuff is the big thing though.

Looking forward to seeing this happen, I think its a great idea.

Subscribe. Want to help somehow.

There have not been replies in the last week. I am marking this application as won't fix.

Please re-apply for a CVS account when you will be able to change the code as reported by voxpelli in comment #3.
The application has been already declined; changing the status of this report doesn't change the status of the application.

1. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted; comments need to be wrapped at column 80.

3. /**
    * Implementation of hook_perm().
    */
   function hosting_serviceapi_perm() {
     return array(
     'load site data',
     'list sites',
     'create site',
     'backup',
     'clone',
     'delete',
     'disable',
     'enable',
     'import',
     'reset',
     'migrate',
     'restore',
     'verify'
    );
   }
   

   The last permission strings don't respect the format used by Drupal, which is <verb> <object>.

There have not been replies in the past week. I am marking this application as won't fix.