check_plain runs twice on title

I encountered the same problem with 6.x-1.0-beta4. I'd consider this a top-priority fix since it results in mangled feed item titles.

TCRobbert's code above replaces views_rss_views_fields.theme.inc lines 68 through 72 FYI.

I had the same problem - edit above appears to have fixed it.

The problem isn't with the title field persay, but with the node title field handler, which does check_plain automatically on render. This could affect anything, including description, for instance. I have attached a "fix" which does htmlspecialchars_decode and then check_plain's. An ideal fix would involve PHP 5.2's option to htmlspecialchars which doesn't allow double encoding...not supported for lower versions though. This is probably a reasonable fix and RTBC, no much better way of doing it that I see. Thanks for the find.

Previous patch committed.

After upgrading to beta5 this issue has reappeared - my title field is outputting html entities (see http://www.glu.org/en/feeds/ais).

I never installed the patch, just used the code in the original post. Thoughts on what might be happening?

Even I am having the same problem. I downloaded the latest beta5 and still the titles and teasers have the html special characters.

Anybody has a solution for this?

I was experiencing this issue with 1.0-beta5. My quick solution was just to copy the template_preprocess_views_rss_fields_item() function from views_rss_views_fields.theme.inc in to my theme's template.php and then rename and modify it in a similar fashion to TCRobbert's code above:

/**
 * Template preprocessor for views-rss-fields-item.tpl.php.
 */
function theme_preprocess_views_rss_fields_item(&$vars) {
  $item = $vars['item'];

  // Loop through key=>value pairs
  $row = '';
  foreach ($item as $key => $value) {
    if ($value) {
      if ($key == 'title') {
        $row .= "<$key>" . $value . "</$key>\n";
      }
      else {
        $row .= "<$key>". check_plain(htmlspecialchars_decode($value)) ."</$key>\n";
      }
    }
  }

  $vars['row'] = $row;
}

I think David's patch works well except that by default, htmlspecialchars_decode() doesn't decode single quotes so I was getting & #039; in my titles.

Adding the ENT_QUOTES parameter fixes that.

$row .= "<$key>". check_plain(htmlspecialchars_decode($value, ENT_QUOTES)) ."</$key>\n";

icosa's fix to David's patch fixes the issue for me.

thanks, icosa and David!

I have created a new patch with the changes you submitted. It was very helpful.

Thanks a lot!

works perfectly for me - are there still any potential issues with that or can we mark this as tested and get it committed?

Patch in #12 worked for me.

Fix #10 (patch #12) committed to 6.x-1.x-dev.