This function

http://api.drupal.org/api/HEAD/function/node_type_update_nodes

Doesn't update the permissions for the content type, so is incomplete.

However, I'd like to challenge the assumption that users should be able to change the machine-readable name of the content at all. Once a new node type is created, if this name is fixed, it would seem to make all the coding simpler.

If you don't like your machine-readable name, the content type can be deleted and a new type created, right?

Comments

pwolanin’s picture

pwolanin commented
Title: node_type_update_nodes doesn't set permissions » node types should not change
Assigned: Unassigned » pwolanin

Following up my e-mail to the devel list, I'll now propose that the ability to re-name types should be removed from core, and a new hook should be created for modules to act on node-type deletion

moshe weitzman’s picture

moshe weitzman commented

you make some good points, but i think we just need some bug fixes. no need to remove the feature based on the examples given. it is really quite ugly to have misnamed types on your site which will happen over time as the use of content types changes.

> Allowing users to change the node type will potentially create
> problems- for example with organic groups, where the names of "group"
> types are saved in a variable and there is no hook to let the module
> know they have been changed.

hmmm. if the old and new values are in the form submit, then og and other modules can just register submit handlers. hooks are old news now.

>
> Also, the current code fails to update user permissions (which are
> construced from the node type), if the name of the type is changed.

please file a bug, or retitle this issue.

Jaza’s picture

Jaza commented
Category: bug » task
Status: Active » Closed (works as designed)

I have posted a response on the devel mailing list, giving detailed reasons as to why I think that this feature should stay in, and should NOT be removed from core.

I have filed an issue for introducing a nde hook_node_type():

http://drupal.org/node/80257

And I have filed a bug for the issue with permission names not updating when a node type's name changes:

http://drupal.org/node/80253

Please post updates specific to these issues in the threads listed above. And please continue any philosophical or design-related discussion on the mailing list thread.