Closed (fixed)
Project:
Drupal.org CVS applications
Component:
co-maintainer application
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2010 at 20:49 UTC
Updated:
21 Oct 2018 at 17:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jerodfritz commentedThe most current files can be downloaded using:
git clone git://github.com/centogram/views_infinite_scroll.git
Comment #2
sunhuh? How's that differnt to http://drupal.org/project/views_infinite_pager ?
Comment #3
jerodfritz commentedah, his is for views2 and mine is for views3 and i didn't see that he had released code either. So we're moving forward with adding this as a separate branch for views3 under that project you referenced. Will I be able to get a cvs account to maintain the views3 branch?
Comment #4
avpadernoThat will happen only if the current maintainer gives his approval.
So far, I agree with sun; the proposed module should not duplicate the work done in existing projects.
Comment #5
thebuckst0p commentedI'm the maintainer of Views Infinite Pager and I have no objection to jerodfritz working on a Views3 branch of the module while I polish the Views2 copy. As I understand it, Views3 uses a different "pluggable" pager system, so a port of the same code might not work, but we can hopefully learn from each other's methods and bring them closer together.
I'm assuming jerodfritz will rename his Views3 module to views_infinite_pager as well? I've been swamped lately as I noted in the issue threads there, but as soon as I get a chance, I'll go on IRC and ask for some assistance with branching in CVS.
Thanks
Comment #6
jerodfritz commentedYes, I'll be renaming the module and rework all of the code for project name views_infinite_pager before the initial commit.
Comment #7
jerodfritz commentedAlso I should mention please use jerodfritz for the account name.
Comment #8
sun@thebuckst0p: Was that a confirmation that you accept @jerodfritz as co-maintainer for your existing project, so both of you can commit changes to it?
If I'm not mistaken, then Views/CTools allows you to register your plugins, even for different versions - i.e. the module could contain 2.x and 3.x plugins at the same time (in different files and/or sub-directories), but only expose those plugins that are compatible with the installed version of Views/CTools. At least, I think that this is how it's supposed to work.
Comment #9
jerodfritz commented@sun, I will look into the plugin registration and if that is the case we will add code to conditionally select the different version within the same project and avoid the branching of separate modules.
Comment #10
thebuckst0p commentedI confirm/accept @jerodfritz as co-maintainer on the premise that he'll develop a 2nd branch, yes. I have to trust him to follow through on that obviously, but I have no reason not to.
Re: CTools plugins, my understanding was that only Views3 utilized those for pagers, Views2 does not, so that wouldn't apply, but I might be wrong.
Thank you
Comment #11
avpadernoComment #13
avpaderno