just installed, the cvs version of the module into a new drupal instance (4.7.3)... but the tidy.exe in the bin folder etc; checked the module under settings to activate it.... then blank screen, nothing, not a thing.... can get to anything at all under the drupal site. had to delete the module from the system, drupal returned, with the following error relating to htmltidy:

array_merge() [function.array-merge]: Argument #2 is not an array in C:\Program Files\Apache Group\Apache2\htdocs\andy\modules\htmltidy\htmltidy.module on line 145.

Comments

ajudson’s picture

ajudson commented

if i use the 4.7.0 version of the module it installs better... at least doesn't do the blank page thing. but its now saying it can find tidy.exe but that tidy.exe -v doesn't respond properly, please advise ?

drewish’s picture

drewish commented

you'll need to try it with the DRUPAL-4-7 branch, i haven't commited any changes to HEAD yet.

drewish’s picture

drewish commented

whoops, looks like i cross posted with you. can you post the actual error message you're getting from the 4.7 branch?

ajudson’s picture

ajudson commented

cheers for instant reponse :)

-- error msg --
HTMLTidy executable is not available. Found 'tidy' binary, but it didn't run right. C:/Program Files/Apache Group/Apache2/htdocs/andy/modules/htmltidy/bin/tidy.exe -v failed to respond correctly

drewish’s picture

drewish commented

humm, i wonder if it's the spaces in the filename? can you put it in a different directory and try it again?

ajudson’s picture

ajudson commented

really strange i thought that too, tried it before i posted the msg but it didn't work, just tried again and it works... thanks, but sorry for wasting your time; that surfices as a solution for now, but it should be fixed anyway.

drewish’s picture

drewish commented

could you put the file back and try changing line 529 of htmltidy.module from:

  $command = escapeshellcmd("$tidypath -v");

to:

  $command = escapeshellcmd('"'. $tidypath .'" -v');
ajudson’s picture

ajudson commented
Version: master » 4.7.x-1.x-dev

tried but returns the error still

xjm’s picture

xjm
she/her
Primary language English
commented

I encounter the same issue: when I put the htmltidy directory with bin/tiny in my modules folder and then go to the modules page, the page is returned as an empty document. I should note that the rest of my site is not affected (as naturally I haven't enabled the module); just the modules page is empty. I am unable to generate any sort of error message

I tried both 4.7.0 and the CVS version from Aug. 19. I encountered the same thing in both cases.

xjm’s picture

xjm
she/her
Primary language English
commented

Update: looks like my admin has php errors turned off. When I tried to install htmltidy on a home machine I got this error on the modules page (instead of a blank page):
Parse error: parse error, expecting `')'' in /[...]/drupal/modules/htmltidy/htmltidy.module on line 514

michaelfavia’s picture

michaelfavia commented
Status: Active » Closed (won't fix)

Sorry I cant support 4.7 on this module. if anyone would like to step forward you are welcome to maintain it. otherwise support will be limited to latest drupal core version and the one that preceded it.