Menu weight not being set properly.

Firstly, thanks to cangeceiro for his work on the patch to add menu weight, etc to the taxonomy menu. (http://drupal.org/node/737478)

His comments in the patch are correct:

Set the weight. We need to do this because the menu system does not order the terms the same way that the taxonomy system does.

There are just 2 issues:

1) The variable taxonomy_menu_weight is not reset for each bulk update, so it always increases in value. After doing several test bulk updates, I managed to get to 975.

2) Issue 1 would not be a huge problem if Drupal did not have a limit to weight. I believe the range is: -50 to 50 by default. So when the modules tries to apply a weight of 975 to a menu item, it defaults to -50. So when I bulk update a menu I end up -50 for all items - which creates a real mess for my Taxonomy menu with 275 menu items.

My temporary solution is to install a small module that I found here which allows you to change the weight range.

I think to get the weight to work properly for large taxonomy vocabularies (larger than 50), it will be necessary to make a few changes:

1) Set the default value of taxonomy_menu_weight to -50 if it does not exist, not 0:

    $weight = variable_get('taxonomy_menu_weight', -50);

as it was, it would only allow for 50 new items to be added to the menu: 0 to 50.

If the default value was -50 it would atleast allow for the 100 items.

2) Delete the variable taxonomy_menu_weight everytime the bulk operation is completed. That way it will get the default value (-50) each run.

3) Add logic to the weight value assigned which corresponds to the menu system of weight.
ie. When there is a sub-menu, the weight can be reset to -50 for the first item, -49 for the second, etc - but for the next menu item (not part of the sub-menu), it will need to reassume from the previous weight value. (does this make sense?)

Andrew