Dim comments with [n] negative comments

There is a $points variable inside the widget template(retrieved on vud_widget_proxy()), which is calculated using:

  $result_criteria = array(
    'content_type' => $type,
    'content_id' => $content_id,
    'value_type' => 'points',
    'tag' => $tag,
    'function' => 'sum'
  );
  $vote_result = (int) votingapi_select_single_result_value($result_criteria);

So, what we need to do is set a class on comment depending on vote_result value.

Here's an updated patch (untested) but I think it should work.

I think there is a solution better than override the comment theme (there are themes with customized comment.tpl.php already). The collapsed part is great. Why just make the comment $content collapsible? It's even better if there is a text "click here to show the comment", when clicking on it, the text will be replaced with the content. But I don't know if something like that is available, or is it easy to implement with jQuery.

There are also some debug code in the last patch: ($comment->cid > 89654 && strpos($base_url, 'groups')) || ($comment->cid > 1266382)

That's not debug code, it's for the drupal.org theme. realityloop is working on this in part for groups.drupal.org (which is awesome of him) so his code may include some site specific things which should not be committed to the main project directly.

Thanks for the work here.

It would be great if you split the patch in two: one in this issue for the relevant code, and other in #786902: Review code with coder about code standards.

The patch works only if I use the proposed comment template in my theme(garland by default overwrite comment.tpl.php). It seems like the only way to accomplish that because there is not a $classes variable inside the comment. I'm not really convinced about that solution.

Other alternatives(making the decision in the theme preprocess function instead of inside the comment template) could be:

- define a theme variable for comment.tpl.php template, and let the user put that variable in his template.
- hack the $status variable to include the relevant class.

But those are neither "good" solutions, so I'm open for suggestions.

About css it seems to the only way to get cross-browser opacity now, so great.

Naturally, please do not include g.d.o custom code in the patch.

I suppose I need more feedback about the right way to "dim" irrelevant comments, so opacity is a good option, but auto-collapse could be another one(kind of what slashdot use). So if someone has more options about that, please join the discussion :-)

I think the easiest way, and suitable for most themes, is something like this in the preprocess:

if ($need_deem_it) {
  $content = "<a id='show-comment-12345'>Click here to show hidden comment</a><div id='wrapper-comment-12345' class='comment-hidden'>". $content ."</div>";
}

And some jQuery script to remove/switch class on a click over ^show-comment

My €.02

Thanks for the quick response :-)

Some suggestions:

- Insert the logic about marking as dimmed in the preprocess function(vud_comment_preprocess_comment())
- use vud-comment-dimmed as the class to identify it.
- IMHO this hunk is not necessary:

@@ -226,7 +228,10 @@ function vud_votes_proxy($content_id, $t
   }
   else {
     $variables['points'] = $vote_result;
-    if ($vote_result < 0) {
+    if ($vote_result < variable_get('vud_comment_dimmed', array())) {
+      $variables['class'] = 'negative-dimmed';
+    }
+      elseif ($vote_result < 0) {
       $variables['class'] = 'negative';
     }
     else {

.. since the real use of the class is by printing on comment.tpl.php
- vud.module is not modified, avoid that hunk too
- make dim feature optional, by setting a flag in vud_comment configuration page.

Subscribing. Thanks

Hi,
I love fun stuff, so I played around with it happily, and here is the results in my test bed:

1. I wanted to have great control on placing the widget, so I simply disable "Node type" selection and put the widget anywhere in the comment.tpl. This prevents double widgets. Setting -1 to trigger dimmed comment. And it FAILS to work.

2. I tried to go the regular placement by enabling one of the node types, it indeed WORKS.

So my expectation for improvement, can you possibly make the dim independent from "node type" selection, so it can also work when the widget is pulled apart from $comment object? The reason is the widget is working outside the $comment, so the dim hopefully can also work outside $comment object.

Thanks for a very sweet additional feature.

I have exams right now, but I'll take some time out today (hopefully) and do a review.

Ok, sorry for not being clear.

I have two ways to display the vud widget, and notice that dim only works with way #2:

1. Anywhere. I can only do this if I DISABLE "node type" option at admin/settings/voteupdown/comment. This is to prevent the appearance of two widgets within comment.tpl (one default widget contained by $comment and another by my custom placement).

2. Default. As is contained by $comment, and I have to enable "node type" option at admin/settings/voteupdown/comment

So this dim functionality will be great if only works with way #1 as well.

Thanks.

I know this is not the right solution, since this is hard-coded to my specific need, but works when my widget is placed anywhere outside $comment:

<?php
$tag = isset($variables['tag']) ? $variables['tag'] : variable_get('vote_up_down_tag', 'userpoints_karma');
    $criteria = array(
    'content_type' => 'comment',
    'content_id' => $comment->cid,
    'value_type' => 'points',
    'tag' => $tag,
    'function' => 'sum'
    );
   $vote_result = (int)votingapi_select_single_result_value($criteria);
   if ($vote_result <= -1) {
     $vud_comment_dimmed = ' vud-comment-dimmed';
   }
?>

So I'll wait for your patches to get into the module.

Thanks

Re #25: "two widgets displayed" seems to be unrelated, please take a look at How to display voting widget by API? (I think the error is just because you are disabling votes for that type).

Thanks for the changes realityloop!

Finally I going to review this today in some hours :-p at a local user meeting! .. sorry for the delay but, like Pratul, I have one exam today.

In the other hand, make this generic to other entities(nodes and terms) sounds pretty good, but not sure how to do that, so let's see what I can do in the afternoon.

Ok, finally I could review this :-)

I've seen some notices in various places and I decided to use dependent from ctools ;-) (BTW ctools is great!)

So, I have a new patch that:

• change the default behaviour to not use dim comments, so I also removed the INSTALL.txt
• load dim css only on comments(vud_widget_proxy is for all types)
• use two variables instead of one for dim configuration(active/inactive and dim threshold)
• validate the input at configuration
• move the dim logic from comment view to comment preprocess(IMHO is clearer there), also remove some unnecessary logic in that code portion.
• remove spaces at css

In the other hand, I think dim really applies naturally only for comments, so that's the reason I did not try a more general approach.

about using collapsible divs, IMO it would be great to have that, but I think it should be in another issue, so feel free to create it

Please take a look at this patch, I hope we can commit this soon ;-)

#29 works like a charm with custom widget placement, and plus +1 for cTools. Thanks

UPDATE: I should rephrase it correctly, since cTools is already in 6.2*, that additional cTools setting is a real plus. I am learning much :)

I think this issue should really focus on comments only. If people want to add it to nodes or other objects (I can see cases where it makes sense) then that could be another issue.

Once we get this committed the question becomes, when can we roll out 6.x-2.x-dev to groups.drupal.org :)

committed.

About g.d.o, mayb eis better to wait until a beta since I marked some issues as release blockers today :-p (aka finally I could read the whole queue)