I couldn't notice any difference between 'slow', 'normal' and 'fast' animation speeds and when I looked in to this I saw that the correct key wasn't being passed to the Javascript. Superfish expects the usual Jquery animation values of 'slow', 'normal', 'fast' or a value in milliseconds but Nice Menus passes the id of the dropdown '0/1/2'. I've supplied a simple patch against 2.x-dev that fixes this and now the animations are noticeably different.

I notice that this same fix is included in the much larger patch #675644: Multilevel menu type implementation but is supplied here on it's own in the hope that it'll get rolled in quicker.

Paul

CommentFileSizeAuthor
#1 nice_menus_animation_speed_fix.patch543 bytespaul_gregory

Comments

paul_gregory’s picture

paul_gregory commented
StatusFileSize
new nice_menus_animation_speed_fix.patch543 bytes

I'm sure there was a patch with my comment originally. Attaching again!

add1sun’s picture

add1sun commented
Status: Needs review » Reviewed & tested by the community

Yeah, I noticed this myself and hadn't gotten to patching it. Thanks! Will roll this in this week for a new beta.

add1sun’s picture

add1sun commented
Status: Reviewed & tested by the community » Fixed

Added to HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.