The install function doesn't install the DB schema properly. There is an obvious error in hook_install() where an undefined $module variable is used. However, fixing that didn't help and I haven't had time to debug it properly.

Comments

3dloco’s picture

Hello zoo33,

I'd like to test out your rules integration patch #531558: rules integration and was wondering what dev version should I use so that it installs properly.

I'm particularly interested in converting images to video and putting the converted video in a separate filefield, where users can also upload additional videos.

Appreciate your help,

KH

[EDIT]Would you be able to post your current working dev version...thanks[/EDIT]

zoo33’s picture

Hi. That patch is against the 2.x branch. I'll commit it shortly so you'll be able to download the 2.x-dev version and use it right away. Please post any further questions about the Rules integration in that thread.

3dloco’s picture

Status: Active » Closed (fixed)

Thanks a lot, this is working for me now.

zoo33’s picture

Status: Closed (fixed) » Active

Sorry, but this issue is still about the install function failing, this is not resolved.

3dloco’s picture

Ok thanks, after a fresh install I ran update.php and everything seems to work ok.

zoo33’s picture

Status: Active » Fixed

Committed a fix.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ñull’s picture

Status: Closed (fixed) » Active

Still not fixed. After install I get:

user warning: Table 'drupal6.ffmpeg_converter_preset' doesn't exist query: SELECT * FROM ffmpeg_converter_preset t__0 in /srv/www/htdocs/c2/drupal6/sites/all/modules/ctools/includes/export.inc on line 379.

No database table is created.

zoo33’s picture

Priority: Critical » Normal

Sorry, I can't reproduce this problem with the latest 2.x-dev version. Could you please make sure you have the latest version, and make a clean install of the module? If you want to start fresh without reinstalling Drupal, you can simply delete the ffmpeg_converter row in the system table – assuming you're using a testing site.

ñull’s picture

Returning here to check out things, I see the same error when I use the present dev.

ñull’s picture

bump

I used the dev version that did not change since February and get the same error. Cannot save presets this way and cannot continue testing this promising module. Sad....

Just after install I get the message:

The plugin definition of ffmpeg_converter_ctools_export_ui cannot locate schema ffmpeg_converter_preset.

Work around is to /update.php and manually select update 6000 of this module, which will create the missing table.

zoo33’s picture

Status: Active » Postponed (maintainer needs more info)

Still can't reproduce this. Some details:

I installed Drupal and the related modules:

drush dl drupal-6
cd drupal-6.22
drush dl ffmpeg_converter-6.x-2.x-dev ffmpeg_wrapper ctools rules drupal_queue

-- install a Drupal site normally

drush en ffmpeg_converter ffmpeg_wrapper_ui rules drupal_queue

-- The result reads:

ffmpeg_converter was enabled successfully.                           [ok]

After that I can go to FFmpeg Converter's admin page and add new presets. The table "ffmpeg_converter_preset" is correctly installed.

These are the versions I used:

 Drupal core      6.22           6.22           Up to date
 Chaos tool suite 6.x-1.8        6.x-1.8        Up to date
 Drupal Queue     6.x-1.2        6.x-1.2        Up to date
 FFmpeg Converter 6.x-2.x-dev    6.x-2.x-dev    Up to date
 FFmpeg Wrapper   6.x-2.0-alpha1 6.x-2.0-alpha1 Up to date
 Rules            6.x-1.4        6.x-1.4        Up to date

It would be nice to be able to close this and maybe make a new release. Please check your versions and see if you come up with any new leads... Thanks!

osopolar’s picture

@ñull maybe you had some errors while installing or updating the 6.x-2.x-dev version of the module so the table was not created. Maybe just reinstall the module (disable + uninstall + install). Have you checked, if the table exists in your database.

I installed the module and the table ffmpeg_converter_preset was created fine. However I was not able to uninstall it correctly because of the missing uninstall hook (#1235812: Implementation of hook_uninstall). Without this a fresh install might fail.