I need to override the payment instructions depending on cart contents. I added a theme function theme_uc_bank_transfer_bank_details().

CommentFileSizeAuthor
uc_bank_transfer-theme.patch1.63 KBjonathan_hunt

Comments

jonathan_hunt’s picture

jonathan_hunt commented
Status: Active » Closed (won't fix)

Doh! Order isn't available this early in checkout. But a theme function would still be useful.

jonathan_hunt’s picture

jonathan_hunt commented
Title: Output cart details via theme » Output bank transfer details via theme
Status: Closed (won't fix) » Active

Not sure why this went to won't fix. The theme function is still very useful. I don't know why the original code is using order id though, as the order is available during cart/checkout.

xibun’s picture

xibun commented

@jonathan_hunt:
1) you put it to "won't fix" yourself
2) order id is not available before "review" page. order ID is useful to match received transfers with orders.

xibun’s picture

xibun commented
Status: Active » Needs review

@jonathan_hunt: still not sure what you meant by "I don't know why the original code is using order id though, as the order is available during cart/checkout." - did I answer your question in my last post? - btw: thanks for the patch !

I put this on "needs review" - I would love to hear about / understand a use-case before committing. I'm wondering if it makes sense to have the theming function the way it is now. Maybe uc_bank_transfer_bank_details should be merged into theme_uc_bank_transfer_bank_details?

YK85’s picture

YK85 commented

subscribing

YK85’s picture

YK85 commented
Status: Needs review » Reviewed & tested by the community

+1 for committing further theme overrides to help administrators customize the pages. Thanks!

checker’s picture

checker commented

+1

xibun’s picture

xibun commented

as mentioned under #4: I would love to hear about / understand a use-case before committing. I'm wondering if it makes sense to have the theming function the way it is now. Maybe uc_bank_transfer_bank_details should be merged into theme_uc_bank_transfer_bank_details?

checker’s picture

checker commented

The anwser is customizing. In my way i don't want to show iban and swift to customers that don't need it.

xibun’s picture

xibun commented
Status: Reviewed & tested by the community » Fixed

commited. thanks jonathan_hunt & checker.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.