Determine feedback to be provided back to clients when they push to d.o [#782610]

We have fairly granular capabilities to send string messages back to clients on push events via the various githooks. Being that collaborative text editing isn't very well-suited to the issue queue, I've added a section to the phase 2 list where we can work on them. This issue is a placeholder to be closed once we've gotten together enough of the scenarios over there to satisfy phase 2.

Here's an initial list of the scenarios we may want to write response messages for:

Successful push (probably nothing extra over what git does already)
Rejected push - push would result in a non-fast-forward merge (any repo)
Rejected push - user has no perms at all on the target repo (project repo)
Rejected push - user has perms on the target repo, but not on the target branch (project repo)
Rejected push - user's git privileges have been temporarily suspended (any repo)
Rejected push - user's git privileges have been permanently suspended (any repo)

Note that I have no idea how well various different clients will respond to these messages (iirc, this is a problem we currently have with CVS), so it may turn out to be imprudent that we use any of these at all.

Comments

Comment #1

webchick

she/they

English

Vancouver 🇨🇦

commented 6 August 2010 at 07:15

Issue tags:

+git low hanging fruit

Tagging. This might be a good task for a volunteer to tackle.

Comment #2

sirkitree commented 6 August 2010 at 11:09

Let's define what some of these mean to a user.

Successful push (probably nothing extra over what git does already)

(none)

Rejected push - push would result in a non-fast-forward merge (any repo)

The repo you are trying to push to has changes in it that your local repository doesn't have. Please (recommended method? fetch rebase/merge?) and try to push again.

Rejected push - user has no perms at all on the target repo (project repo)
Rejected push - user has perms on the target repo, but not on the target branch (project repo)

Pretty self explanatory. But maybe the message should reflect what the user should do to get perms?

Rejected push - user's git privileges have been temporarily suspended (any repo)
Rejected push - user's git privileges have been permanently suspended (any repo)

We probably don't have access to "why" but we can give a message to give the user a clue as to how to get these back.

Comment #3

webchick

she/they

English

Vancouver 🇨🇦

commented 9 August 2010 at 19:41

Issue tags:

-git phase 2

+git phase 1

Fixing tag.

Comment #4

sdboyer commented 10 August 2010 at 06:07

Issue tags:

-git phase 1

+git phase 2

Should be phase 2.

Comment #5

eojthebrave

he/him

English

Minneapolis, MN

commented 13 August 2010 at 13:33

It might be nice to include links to pages on d.o. where we give a better explanation of what just happened and how to resolve the problem, at least in the case of rejections. That would allow us to keep the messages we send nice and succinct, but allow users to have a quick and easy place to get more information about resolving their issues.