I can upload mp3 with the Audio Module but I don't think the getid3 module is working with it because the Title and Artist tag is always blank and I have to fill that in. It also doesn't read the length, sample rate, bit rate... Everything use to work until I got the last version of the Audio Module that was dated 8/10/2006. I have attached a screen print. The mp3 file I'm uploading has proper tags in it.

CommentFileSizeAuthor
screenprint.gif13.53 KBclashfan

Comments

drewish’s picture

did you make sure to enable the audio_getid3 module?

clashfan’s picture

Yes the getid13 module is enabled. Like I said everything was working fine until I uploaded the newest cvs version.

sun’s picture

Also having the same problem with activated audio_getid3.module, downloaded getid3 1.7.7 library and configured path to getid3 library in settings of audio.module.
Uploaded file has proper id3v1 tags.
In difference to clashfan I'm running my sandbox on Windows.

Even with activated getid3 warnings there are no warnings displayed.

sun’s picture

Although ID3 information is not read from my test files, the ID3 tags are written to disk.

btw: The written ID3v2 tags are corrupted - artist and title are shortened to a length of 7 chars and album title is shortened to 4 chars. Track number is also missing. ID3v1 tags are looking fine.

drewish’s picture

humm, i can't make any promises about how well the module will work with HEAD. there's been a lot of big commits to Drupal HEAD that i haven't been able to account for. patches would be welcome.

sun’s picture

btw: Problems described by me occur in audio-4.7.0.tar.gz, not HEAD.

drewish’s picture

sun, just to be clear, you're running Drupal 4.7 correct?

sun’s picture

Correct, I'm running Drupal 4.7.2. I've also already tried getid3 v1.7.6 for troubleshooting but results are identical.

drewish’s picture

Humm, I haven't been able to recreate the problem. What version of PHP are you running?

sun’s picture

PHP Version 4.3.11 on Windows Apache.

fractal’s picture

I am having the same issue here. I've tested it on debian sarge and ubuntu 6.06 with drupal 4.7.3 and have the same problem. I haven't got that problem before 10 aug. I think after 10 aug the audio-4.7.0.tar.gz changed. Is there a way to download that version of audio-4.7.0 (before 10 aug, I deleted it accidentally) which worked fine with plain install of drupal 4.7.3

drewish’s picture

fractal, same question, what version of PHP are you using? you can always pull out old versions of a module from CVS.

fractal’s picture

My version is PHP 4.3.10(-16), Debian Sarge 3.1, getid3 1.7.7 .I change the permissions of drupal installation to default apache user (www-data). And for cvs I will check the command's syntax.

drewish’s picture

okay, it looks like this is PHP4 specific. after i broke down and installed an old version i was able to recreate the problem. i'll try to get a patch posted shortly.

drewish’s picture

Status: Active » Fixed

okay, it turns out that module_invoke_all() will pass parameters by reference under PHP5 but not PHP4. I've added audio_invoke_audioapi() to work around this.

clashfan’s picture

I'm still having the same problems(no title, artist, bitrate...). Maybe I downloaded the wrong file? Can you provide a direct link to the download?

clashfan’s picture

Nevermind I found the download. Works great now. Thanks for the fix.

drewish’s picture

well, it kind of depends on when you downloaded it. looking at the project's release page it looks like a new version was built a few minutes before your bug was posted, but due to timezones that could be way off. i just double checked the contents of the 4.7 package and it's got my most recent changes. maybe you could try it again?

drewish’s picture

great! glad to hear it's working. if you run into any other bugs please open a new issue.

fractal’s picture

Great! It's working here too. Thank You.

Anonymous’s picture

Status: Fixed » Closed (fixed)