Us user 1 I go to other user profile and delete his messages.

I get status message:

* Deleted 23 threads.
* The previous action can be undone.

But messages are still in users inbox.

CommentFileSizeAuthor
#3 privatemsg_delete_others_with_tests.patch5.77 KBberdir
#1 privatemsg_delete_others.patch3.38 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new privatemsg_delete_others.patch3.38 KB

Confirmed. We don't pass the account object around currently.

Attached is a patch that should fix it, I want to write some tests for this too but this should be a starting point. The existing tests should atleast tell if this doesn't break anything else.

this also needs to be ported to 6.x-1.x and 7.x-1.x once it's done.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new privatemsg_delete_others_with_tests.patch5.77 KB

Same changes as before, just with tests.

benone’s picture

benone commented

Could you attach original files. I would like to test it also, just have no knowledge and soft to patch the module.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Patching isn't that hard, check out http://drupal.org/patch.

Also, I've applied the patch to the recently (as in, today) created demo website, see http://demo.worldempire.ch. The admin user is pre-configured to have the read all private messages permission.

benone’s picture

benone commented

I checked site. Patch works ok.
But believe me patching is a nightmare. I already tried doing this but without any results.

Did you commit also this critical bug patch which was anounced today about privatemsg to DEV 2.0 version ?
Let me know when the patch will be commited.

THanks

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Ha, probably depends on the OS. On Linux, patching means executing two simple commands :)

Yes, the security fix has been commited to 2.x-dev too but since it is a development release, there was no official security announcement.

Ok, greating, thanks for testing, will commit this soon.

benone’s picture

benone commented

Yeay, on windows it's really annoying task..

Thanks for Re and I am waiting for commit.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reporting and testing, the patch has been commited to all branches.

benone’s picture

benone commented

Hey I just updated 6.x-2.x-dev and still admin cant delete others users messages :(
The same what in the first post.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

-dev snapshots are only updated every 12h and has been updated on the third the last time. That means, you have to wait a few more hours :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.