Block formatting clean up

tanc - August 12, 2006 - 09:40
Project:Content Moderator
Version:4.7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

First of all thanks for writing this module, it fills a gap in my drupal sites. I've attached a patch to clean up the block output so it formats correctly and is in line with other blocks' style. I've made the block title static rather than linked and instead placed a 'more' link at the bottom to take the user to the admin area. This is my first patch and I hope it works.

Regards,
Tanc.

AttachmentSize
content_moderator_block.patch923 bytes

#1

pwolanin - August 19, 2006 - 16:30

Ok, I'll take a look- that's for supplying a patch. i think I linked the block title in imitation of one of the OG blocks, but I agree that it's non-standard.

#2

pwolanin - August 20, 2006 - 01:54

hmmm, I'm not quite sure I like this patch. The link is not really " more". It's actually the thing that's important. The links (each node title) aren't actually very useful.

Maybe a better idea would be to give a total number in the queue, a link to the page (if you think having the title be the link is bad), and a shorter list (maybe 5) of recent additions to the queue?

#3

pwolanin - August 20, 2006 - 02:29
Status:active» needs review

Please test the attached patch and give me your feedback.

AttachmentSize
better_cm_block_1.diff 1.56 KB

#4

pwolanin - August 20, 2006 - 23:32

slightly better patch- essentially the same functionality.

AttachmentSize
better_cm_block_2.diff 1.64 KB

#5

pwolanin - September 14, 2006 - 22:59
Status:needs review» reviewed & tested by the community

Any feedback? If not, I'll commit my last patch soon.

#6

pwolanin - September 15, 2006 - 23:27
Status:reviewed & tested by the community» fixed

patch committed

#7

pwolanin - September 19, 2006 - 22:57
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.