Synchronize apachesolr_search_browse with apachesolr_search_execute

Not sure this is exactly the kind of change you were hoping for (since it's not really refactoring, just adding the functionality), but here's a patch that at least gets hook_apachesolr_prepare_query() in apachesolr_search_browse().

minor, but

+    $function_name($query, $caller);

versus

   apachesolr_modify_query($query, 'apachesolr');

Looks like the 1st call may be referencing an undefined variable.

Not sure I'm following you. $caller is one of the function arguments, if there's a chance that could be undefined shouldn't we set a default value of 'apachesolr'? Or is there something else that might be undefined?

ok, if it's one of the fucntion arguments, then the latter call shoudl not be hard-coded to 'apachesolr'

Sorry, I was looking at the wrong part of the code (doh). Here's a fixed patch.

Updating status since I added a new patch.

Please stop using git format-patch

Sorry, I was following the directions outlined by the git migration team (http://drupal.org/node/1054616). What is the preferred approach? Since your preferred approach is different shouldn't we try to get the git instructions changed?

The documentation does briefly mention git diff but doesn't go into any real detail for using it.

Wow that doc sucks - that multi-commit formating makes it near impossible to review the patch visually.

I have edited the doc to indicated usage of git diff
http://drupal.org/node/1054616

I rerolled your multi-commit file above to a single diff

Thanks, the documentation should probably also be updated on the project git instruction pages (i.e. http://drupal.org/node/204268/git-instructions/master ). I'll make sure to roll patches in the way you suggested in the main git instructions document though.

committed to master

Also, re: git tab see: #1092226: Fix git tab instructions to suggest using "git diff" instead of "git format-patch"

Looks good to me.