I have a situation where I have the same block used in different themes and with different settings. If I look at the blocks database I see the correct information in there, but when I try to pull up the block configuration, the information is incorrect (from a different theme).

In looking at block_admin_configure() in block.admin.inc, there is the following select statement:
SELECT pages, visibility, custom, title FROM {blocks} WHERE module = '%s' AND delta = '%s'", $module, $delta

Because this statement does not also look for a theme, the wrong theme/modulename/delta combination may be chosen.

This is what the select statement should look like:
SELECT pages, visibility, custom, title FROM {blocks} WHERE module = '%s' AND delta = '%s' AND theme = '%s'", $module, $delta, $theme_key

The full patch is attached.

I realize this may be considered a duplicate of this issue: http://drupal.org/node/244871

However that issue is for Drupal 5.x and incorrectly states "It isn't an issue with D6..."

Comments

dpearcefl’s picture

StatusFileSize
new836 bytes
dpearcefl’s picture

Status: Active » Needs review
StatusFileSize
new836 bytes

Reattaching the patch in the proper way.

Status: Needs review » Needs work

The last submitted patch, block-themes-78378.patch, failed testing.

dpearcefl’s picture

StatusFileSize
new819 bytes

Sorry, my first time.

dpearcefl’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, block-themes-78378.patch, failed testing.

dpearcefl’s picture

Status: Needs work » Needs review
StatusFileSize
new914 bytes

I'm gonna get this right yet...

Status: Needs review » Needs work

The last submitted patch, block-themes-78378.patch, failed testing.

dpearcefl’s picture

Status: Needs work » Needs review
StatusFileSize
new1.07 KB

Status: Needs review » Needs work

The last submitted patch, block-themes-78378_1.patch, failed testing.

dpearcefl’s picture

Status: Needs work » Needs review

I don't understand why this patch is failing. Can someone tell me why?

dpearcefl’s picture

Version: 6.16 » 6.x-dev
Status: Needs review » Needs work
dpearcefl’s picture

Status: Needs work » Needs review

#9: block-themes-78378_1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, block-themes-78378_1.patch, failed testing.

dpearcefl’s picture

Status: Needs work » Needs review
StatusFileSize
new902 bytes

Trying again.

Status: Needs review » Needs work

The last submitted patch, block-themes-783378_2.patch, failed testing.

dpearcefl’s picture

Status: Needs work » Needs review
StatusFileSize
new883 bytes

noob mistake!

mcarbone’s picture

Status: Needs review » Closed (duplicate)