I have a situation where I have the same block used in different themes and with different settings. If I look at the blocks database I see the correct information in there, but when I try to pull up the block configuration, the information is incorrect (from a different theme).
In looking at block_admin_configure() in block.admin.inc, there is the following select statement:
SELECT pages, visibility, custom, title FROM {blocks} WHERE module = '%s' AND delta = '%s'", $module, $delta
Because this statement does not also look for a theme, the wrong theme/modulename/delta combination may be chosen.
This is what the select statement should look like:
SELECT pages, visibility, custom, title FROM {blocks} WHERE module = '%s' AND delta = '%s' AND theme = '%s'", $module, $delta, $theme_key
The full patch is attached.
I realize this may be considered a duplicate of this issue: http://drupal.org/node/244871
However that issue is for Drupal 5.x and incorrectly states "It isn't an issue with D6..."
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | block-themes-783378_3.patch | 883 bytes | dpearcefl |
| #15 | block-themes-783378_2.patch | 902 bytes | dpearcefl |
| #9 | block-themes-78378_1.patch | 1.07 KB | dpearcefl |
| #7 | block-themes-78378.patch | 914 bytes | dpearcefl |
| #4 | block-themes-78378.patch | 819 bytes | dpearcefl |
Comments
Comment #1
dpearcefl commentedComment #2
dpearcefl commentedReattaching the patch in the proper way.
Comment #4
dpearcefl commentedSorry, my first time.
Comment #5
dpearcefl commentedComment #7
dpearcefl commentedI'm gonna get this right yet...
Comment #9
dpearcefl commentedComment #11
dpearcefl commentedI don't understand why this patch is failing. Can someone tell me why?
Comment #12
dpearcefl commentedComment #13
dpearcefl commented#9: block-themes-78378_1.patch queued for re-testing.
Comment #15
dpearcefl commentedTrying again.
Comment #17
dpearcefl commentednoob mistake!
Comment #18
mcarbone commentedDefinitely a duplicate of #115596: Block custom title, visibility and pages settings get blanked out in block->configure