It would be cool if there would be a views_break_phase_string method which is also used on the string argument handler.

Comments

dawehner’s picture

If someone is wondering what i did in views_break_phase: i replaced "filter" with "handler".

dawehner’s picture

StatusFileSize
new9.63 KB

Rerole.

We should get patches in, unless people shouldn't rerole patches the full day.

merlinofchaos’s picture

Status: Needs review » Needs work
+/*
+ * Break x,y,z and x+y+z into an array. String only.
+ *
+ * @param $str
+ *   The string to parse.
+ * @param $handler
+ *   The handler object to use as a base.
+ *
+ * @return $handler
+ *   The new handler object.
+ */
+function views_break_phrase($str, &$handler) {

This looks like it changes the documentation on views_break_phrase() to what should be on views_break_phrase_string().

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new9.63 KB

You are right. Here is a rerole.

merlinofchaos’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Needs a bit of a port for D7.

D7 may benefit more from providing the string break to CTools instead, as well as tests for both functions.

dawehner’s picture

Status: Patch (to be ported) » Fixed

Ported and played a bit with it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

webflo’s picture

Status: Closed (fixed) » Needs review
StatusFileSize
new913 bytes

I think there was something missed. All arguments are validate in query() but there are invalid in title() because title() still uses the old views_break_phrase() method.

dawehner’s picture

Status: Needs review » Fixed

Sure make sense. Commited to 6.x-3.x and 7.x-3.x

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.