It would be cool if there would be a views_break_phase_string method which is also used on the string argument handler.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | views-fix-title-in-views_handler_argument_string-783514-D7.patch | 913 bytes | webflo |
| #4 | 783514-views_break_string.patch | 9.63 KB | dawehner |
| #2 | views-views_break_phase_string.patch | 9.63 KB | dawehner |
| views-views_break_phase_string.patch | 9.45 KB | dawehner |
Comments
Comment #1
dawehnerIf someone is wondering what i did in views_break_phase: i replaced "filter" with "handler".
Comment #2
dawehnerRerole.
We should get patches in, unless people shouldn't rerole patches the full day.
Comment #3
merlinofchaos commentedThis looks like it changes the documentation on views_break_phrase() to what should be on views_break_phrase_string().
Comment #4
dawehnerYou are right. Here is a rerole.
Comment #5
merlinofchaos commentedNeeds a bit of a port for D7.
D7 may benefit more from providing the string break to CTools instead, as well as tests for both functions.
Comment #6
dawehnerPorted and played a bit with it.
Comment #8
webflo commentedI think there was something missed. All arguments are validate in query() but there are invalid in title() because title() still uses the old views_break_phrase() method.
Comment #9
dawehnerSure make sense. Commited to 6.x-3.x and 7.x-3.x
Thanks!