Download & Extend

Improvements to cookie-based kiosk mode

Project:Kiosk
Version:6.x-1.0
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

I don't think the cookie mode ever worked right, as it used an uninitialized variable for the $expire.

Here's a version that seems to work fine.

I've changed it to either set a cookie with expiration near the end of time() or to remove the cookie. The correct button shows in each case.

In the process I cleaned up some out-of-date comments.

Comments

#1

Here's the patch. I don't know why they seem to get dropped so often lately.

AttachmentSize
kiosk.cookie_improvements_783554_01.patch 4.06 KB

#2

Here's an improvement: Cookie deletion wasn't working quite right.

AttachmentSize
kiosk.cookie_improvements_783554_02.patch 5.69 KB