Upgrade to 4.7 breaks the form or the data

Did you run the http://www.yourdrupalsite/update.php script after updating the module ?

Sorry about the trouble. Did you make a backup of your DB before upgrading? I'd like to have a look at what went wrong. If possible could you sent me a copy of: 1. SQL Dump of the 4.6 webform tables 2. A copy of the webform directory you used in 4.6. If you zip the files and post them to this thread or email them to me (nate@quicksketch.org) I'll try to find what went awry.

Hi

I have same problem, my old submission are lost!!
I had update 4.6.6 to 4.7.3 this morning.

Thanks

capnj: I didn't seem to receive the email. It probably was spam filtered out and I cleaned up my Junk folder on the 20th. Could you send it again. If you mention 'Drupal' somewhere in the email it'll probably get through without getting filtered.

Hi,

I think I have a similar problem too - I've not used the module much so am not sure when the problem emerged: but upgrading to the latest version hasn't helped. My error on submission is:

user warning: Unknown column 'cid' in 'field list' query: INSERT INTO webform_submitted_data (nid, sid, cid, no, data) VALUES (529, 4, 1156759547, 0, '1\r\n2\r\n3') in /home/shared/peterchen/public_html/peterjohnchen.com/includes/database.mysql.inc on line 120.

and the form (in edit) doesn't seem to "hold" the mailto: address. You can check out the error here (http://www.peterjohnchen.com/diplomacy_turn_submission_form_0) if it helps - I'm not so savvy to pull apart the db.

P

I just upgraded webform from 4.6 to 4.73. I ran the update script. The database appears to be intact, and newly submitted webforms appear to be added to the database appropriately.

While viewing the "reports" page I received an array-merge error on line 89 of webform_reports.inc. The follwing change to line 89 seems to have repaired the error (sorry, don't know how to make a patch yet):

- $header = array_merge($header,$componentHeaders);
+ $header = array_merge((array)$header,(array)$componentHeaders);

I'm not getting the "unknown column" error, however, I am having the previously reported problem with data not appearing under the "submissions" tab or the "table" tab on the reports page. The analysis tab appears to be working properly. Newly submitted webforms (since the upgrade) DO appear under the submissions and table tabs.

I too had a similar issue when I upgraded from Drupal 4.6 to 4.7, and ran the update script. It looks like the data is still intact in webform_submitted_data, but nothing is copied over to webform_submissions. New form submissoins to properly get written to webform_submissions, though.

-- Doug

I did a little more digging around, and it looks like _webform_legacy_module() has a call to _webform_convert_old_submissions(), which is commented out. Also, I cannot find _webform_convert_old_submissions() anywhere in the code.

I'm not sure if that was a project that was started at some point or not, but just thought I'd mention that finding.

-- Doug

Is there a solution for this yet? I mean the upgrade from the 4.6 branch to the 4.7 branch?

/Thomas

I added the following code to webform.install as the ninth update function. By doing so I managed to get all the old data back out of the module. The submission time will be the time when the script was run. The original submission time is forever lost (not recorded during 4.6.x). I have only tested it with MySQL.

/Thomas

function webform_update_9() {
  $ret = array();

  $prev_sid = 0;

  $result = db_query("SELECT nid, sid FROM {webform_submitted_data} ".
                     " WHERE 1 ORDER BY sid");

  while ($row = db_fetch_object($result)) {
    if ($prev_sid <> $row->sid) {
      db_query("INSERT INTO {webform_submissions} (nid, sid, submitted)
                VALUES (%d, %d, UNIX_TIMESTAMP())", $row->nid, $row->sid);
      $prev_sid = $row->sid;
    }
  }


  return $ret;
}

Thanks for this. The above worked for me, but I had "Invalid argument supplied for foreach()" errors when viewing the results of forms where select options had not been filled in. The problem seems to be that there is no data at all in the webform_submitted_data table for the sid,cid combination of the empty select statements. To fix this I ran the following database queries:

    INSERT IGNORE INTO webform_submitted_data (nid,sid,cid) SELECT t1.nid,t1.sid,t2.cid FROM webform_submitted_data AS t1, webform_component AS t2 WHERE (t2.type='select') GROUP BY t1.sid,t2.cid ;
    UPDATE webform_submitted_data SET data='' WHERE data <=> NULL;

This adds rows for the missing cid and sid combintations to webform_submitted_data and fills the data field with the empty string. It seems to work, but be warned: I'm an SQL newbie!

Unfortunately if you missed the update to 4.7... I think you're on your own now. I cut support for 4.7 months ago and I'm not going to install 4.6 and try an upgrade. Patches are still accepted though :)