I like your module, but didn't like that the displayed text wasn't configurable. Here is are patches which add a couple settings fields to the Error reporting form. It also makes the 404 page title translatable.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | thrifty404.module.patch | 2.77 KB | oseldman |
| #1 | thrifty404.module.patch | 2.92 KB | joelstein |
| #1 | thrifty404.install.patch | 300 bytes | joelstein |
| thrifty404.install.patch | 263 bytes | joelstein | |
| thrifty404.module.patch | 2.43 KB | joelstein |
Comments
Comment #1
joelstein commentedJust realized that there were two other small problems with the code:
1. There is an misspelled variable.
2. The page title wasn't getting set on the 404 page.
I fixed the variable, and added a configuration variable for the page title.
Comment #2
oseldman commentedUncanny timing. I was working on this same issue earlier today. I ended up writing almost the same code, but did a few things slightly differently, so I figured I'd post my patch, just in case it was useful.
Comment #3
christefano commentedPatches! They look great and I'll probably use parts from each of your contributions. I'll review them more thoroughly as soon as I can.
Comment #4
christefano commentedSorry for taking so long for this "thorough review" but I wanted you to know that this is getting some attention.