Needs review
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Apr 2010 at 14:01 UTC
Updated:
23 May 2019 at 13:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
skein commentedComment #2
dawehnerWhat is this kind of profile field?
It is not so hard to patch views to allow to select also is empty(NULL);
Comment #3
skein commentedIt's a select Type
Comment #4
dawehnerHere is a easy patch.
First it should be discussed what for profile fields should allow empty.
Comment #5
skein commentedHello,
Sorry to bring this up again, but I tried your patch and it didn't work. Did i misunderstand something?
Comment #6
dawehnerMh so
Comment #7
Offlein commentedI think I see what the problem was. That patch is bad, as far as I can tell.
He wrote:
When it should be:
It is "accept_null" instead of "allow empty". Also, it has to go inside that array. This is roughly around Line 152 in views/modules/profile.views.inc. You will need to clear your caches.
Comment #8
michl6 commentedsubscribing
Comment #9
Offlein commentedThis should probably be "Needs review". I think that patch is fine with my change.
Comment #10
dawehner@offlein
See skeins comment.
Additional:
is still open.
Comment #11
esmerel commentedNo work done on patch in more than 3 months.
Comment #12
Offlein commentedHi, sorry, I didn't come back to this.
@Dereine, Skein's comment is in reference to your patch not working. I wrote how to fix the patch, but did not reroll. I am including it here (your patch, edited, but not actually rerolled).
I am not really sure what "First it should be discussed what for profile fields should allow empty" means -- but at first blush it seems outside the scope of this issue?
I was using it to get Profile "selection" fields (I think) to operate when a value has not been selected?
Comment #13
iamjon commentedCan anyone update that this patch actually worked for them?
Marked #977060: Profile filter for EMPTY as a duplicate.
Comment #14
Offlein commented@iamjon Sorry, I didn't reopen this I guess. Did the patch not work for you? What was the error? I believe it worked for me back when I rolled it in September. Or did it apply correctly, but did not do the expected functionality?
Comment #15
dawehner@offlein
iamjon is part of the views bug squad team, so he takes care about the patches.
so your patch will not work. It needs a space instead of a "_"
Comment #16
geaseSeems you are talking about different things.
accept nullmakes new choice appear, 'IS NULL' or 'IS NOT NULL', in the filter options.allow emptymakes empty form field match not only an empty field value (''), but also NULL field value.I think that the latter needs to be incorporated in Views (I'm using current version of 6.x-3)
Comment #17
mradcliffeThis one hasn't been worked on in a while. Updating to latest version and attached patch.
Comment #18
dawehnerDo we really care about profile module integration in d7?
In general this patch looks fine.
Comment #19
chris matthews commentedThe 7 year old patch in #17 does not apply to the latest views 7.x-3.x-dev and if still applicable needs a reroll.
Comment #20
andrew answer commentedPatch rerolled.
Comment #21
damienmckennaFYI the "assigned" field is for indicating that you're actively working on an issue, if you're not actively working on an issue please leave it set to "unassigned". Thank you.