Its a wonderful module. In my opinion a core-feature candidate :-)

But is their a plan for wrapping any type of content, instead of plain-text only?
Is that not possible with the input-filter? Especially in combination with the Image Browser Filter?

Unfortunately i have no idea how to resolve the 'problem', but i want to know what the other think about this feature or that this is already possible and im just to stupid ;-)

Comments

peter törnstrand’s picture

You mean you want to link a image for example? Haven't though about that ... not sure how that would work with the input filter. I'll have a look.

chris_n’s picture

Yes that is exactly what i mean.

There is an other Input-Filter Module: linodef, which is following the same target. Wrapping content with the filter-syntax is still supported, but was deprecated for future releases. :-( Perhaps it can help you searching a - positive or negative - resolution.

I really cant understand, that this is so an unpopular problem in the Drupal-Community. Because in my opinon (and a lot of other People i have talked about with) it is not reasonable to a "normal" user making a hardcoded Link to an internal site.

I know the "drupal way" is using node-references, but this is not suitable for every type of website. Sry for discussing principles here.

Im one of the themer/designer, who is very happy to make so powerful websites with drupal, without having programming skills. But it breaks my heart asking other people instead of doing by my self.

You probably noticed that im very sorry for my request. ;-)

rootwork’s picture

Title: Wrapping Link » Allow node-picked links to wrap other elements

+1 on this feature for me. I'd love to be able to select an image and link it to an existing node.

I'm happy to help test out code for this feature, I just don't have the module-writing chops to start it out on my own :)

rootwork’s picture

Why does Node Picker insert special code -- e.g. [nodepicker==node/58==Title%20of%20node==word] -- instead of a normal link? It seems like if it did the latter, it would be easier to wrap it around other objects -- but I might be totally missing a critical reason it doesn't create normal links, so feel free to school me :)

peter törnstrand’s picture

It creates a special tag so even if you change the URL-alias for a node the link would still work. But this feature causes some other problems, wrapping images etc for instance.

Xermit’s picture

Hello.
I suggested change line 274 nodepicker.module

from

  $link = l($attr['link_text'], drupal_get_path_alias($attr['href']), array('attributes' => array( 'title' => $attr['title'], 'class' => 'nodepicker-link')));

to

  $link = l($attr['link_text'], drupal_get_path_alias($attr['href']), array('attributes' => array( 'title' => $attr['title'], 'class' => 'nodepicker-link'), 'html' => TRUE));

and i don't understand

why do you use utf8_encode and urldecode on title?

I have to convert title text to urlencode code, but i want to set title on my language without url-encoding and to see my title on my language in editor

Is the action in linking ajax?

may be use t() for title?

For self I removed the actions with title because l() function checked it

Are my changes wrong?

For example, now i use

[nodepicker==node/315==My title 315==[#340:field_image_cache:1,formatter="image_plain",nolink]]

without url-encoding

and nodepicker work with linodef

Best regards.

peter törnstrand’s picture

I'm using urlencode because the tag decoding doesn't work with special characters otherwise. Tags get decoded on an AJAX request like nodepicker/ajax?tag=[nodepicker==node/1==My title==My link text] and if this URL contains special characters you get all sorts of strange behaviors.

adiatis’s picture

+1 on this feature

matulis’s picture

Agree with #4 rootwork.
Why not to use Drupal internal paths 'node/123'? see no reason for special tags.

peter törnstrand’s picture

Assigned: Unassigned » peter törnstrand
Status: Active » Postponed

This feature is dependant on the outcome of #819512: Use <a>-tags (instead of custom tags/tokens) and do NOT use URL aliases. If I decide to skip the coding of links wrapping other elements will be implemented.

timwood’s picture

Sub

mlconnor’s picture

+1

sinasalek’s picture

+1

Xermit’s picture

the feature works if you use #6, and you aren't use wisiwyg mode!

[nodepicker==node/315==My title 315==[#340:field_image_cache:1,formatter="image_plain",nolink]]

peter törnstrand’s picture

Issue summary: View changes
Status: Postponed » Closed (won't fix)