Call time pass by reference in latest HEAD version of patterns.module

I am trying out the latest patterns.module in HEAD, since I'm writing some stuff against it and wanted to make sure the API was still clean.

Just wanted to alert to the fact that there is a call time pass by reference happening. Perhaps in your PHP instance you have that turned on, but PHP recommends turning it off as it is deprecated.

I made the change, but it seems to me that something in the logic is going to change with this, so it needs to be looked at by someone with better understanding of the context of this function.

--- orig	2010-04-30 17:02:15.000000000 -0400
+++ new	2010-04-30 17:02:14.000000000 -0400
@@ -731,7 +731,7 @@ function patterns_from_source($xml) {
  * Recurse through the values of a parsed xml file to create a
  * multi-dimensional representation of the data.
  */
-function _patterns_parse_tag($data, $index) {
+function _patterns_parse_tag($data, &$index) {
   $pattern = array();
   
   while ($current = $data[$index]) {
@@ -752,7 +752,7 @@ function _patterns_parse_tag($data, $ind
     switch($type) {
       case 'open':
         $index++;
-        $current += _patterns_parse_tag($data, &$index);
+        $current += _patterns_parse_tag($data, $index);
         $pattern[] = $current;
       break;
       case 'close':