It would be nice to embed clips from other sites too. I know there is the video filter module for this, but don't like their approach where users have to use tags.

Enclosed is a patch that make googtube aware of Vimeo videos and embeds them as per Youtube and Google.

This is very simple patch and have installed and tested on a production system successfully.

CommentFileSizeAuthor
googtube.vimeo_.patch3.41 KBraintonr

Comments

raintonr’s picture

raintonr commented

I notice this hasn't been committed yet. Is there a problem?

I've just added xtranormal too but haven't made a patch given this one hasn't been used yet.

alexandreracine’s picture

alexandreracine commented

I'll test it shortly.

alexandreracine’s picture

alexandreracine commented
Status: Needs review » Fixed

ok, I just uploaded the, now modified, patch to the 6.x-1.x-dev branch. The download should be there when the nightly build get there.

All those points should be consider before uploading another patch. Thanks.

-I did not changed the descriptions yet. There will be more videos, and eventually it will be "multiples videos" instead of adding them one by one.
-I added the regex string so that this would not go in vain : #551924: URL inside an <a> tag is processed.
-I belive that the drupal check_url function should be use, just in case
-The $Id should be with a name, just like other videos, so I changed it to vimeo_id

I did the modifications myself so that I could get in touch again with PHP :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sittard’s picture

sittard commented
Status: Closed (fixed) » Active

Did this patch every make it in the current stable release? I can see on the release page this patch was rolled out with googtube 6.x-1.x-dev (March 2009) but it's not in the current release (March 2010). Any chance this could be updated.

I also don't see a current development release for the 6.x branch on the project home page.

alexandreracine’s picture

alexandreracine commented
Status: Active » Closed (duplicate)

I don't know what happened to the patch, but, you can check out a patch for 6.x that has more option here http://drupal.org/node/1538446