Currently the test are kind of a mess with lots of legacy functions testing the pre-context functionality. Need to go through, cut out the old crap, rewrite functions to handle contexts and generally clean up everything in the tests.

Comments

dave reid’s picture

First step is changing drupalGetSitemap():
1. To use contexts instead of the hard-coded $language parameter.
2. Remove the $regenerate parameter in favor of calling $this->regenerateSitemap() manually.
3. Remove the check for if response was 200 and be more like drupalGet() and not care about the response. Now that we're checking any watchdog messages in tearDown() we'll find any responses that 404'd automatically.

dave reid’s picture

dave reid’s picture

Next step: Adding an xmlsitemap_test.module to actually test the context system and adding/editing/deleting sitemaps.

dave reid’s picture

Priority: Normal » Critical
dave reid’s picture

Priority: Critical » Major

  • Dave Reid committed 544c120 on 8.x-1.x
    #787582 by Dave Reid: Cleaned up drupalGetSitemap() in tests.