Site title is read three times with VoiceOver in Garland.

@joachim

Can you please paste the markup related to the site title on the site that you're testing so that we can take a look to analyze what might be causing the problem? I would imagine that this is possibly a VO thing and that there might be little we can do about it, but I'd like to see the exact page source of this section to know for sure.

@joachim

1. I think we can likely do without the title attribute on the anchor around the image. This redundant since the image has an alt attribute.

2. I may have already opened an issue on the alt for the logo image, if not I will in the future. Short story is we need a theme settings option to allow site admins to change the alt of the image to whatever they would like it to be. This needs to be a D8 thing. There are differing opinions to alt for a logo. Should it be 'logo', or 'Text-on-logo', or 'description of the image in the logo', or a combination of 1 or more of these? Hard to say, and I don't think that there is always a right answer. A picture is worth 1000 words, hard to encapsulate it in the alt attribute, so we need to encapsulate, to the best of our ability, the message / meaning that the image is intended to convey.

@joachim

My only guess, and it's just a guess, is that in Garland the title of the anchor is different than the contents of the anchor (alt + link text), whereas in Stark the anchor title == the content of the anchor (alt alone). I can't stress enough how this is only a guess. Hard to know exactly what logic Apple is using here to decide what to read.

For the custom alt text on logo see:
#717708: Document how to set logo in theme with proper alt tags

Ok, so in Garland the code is now:

      <div id="header">
        <div id="logo-floater">
        <?php if ($logo || $site_title): ?>
          <?php if ($title): ?>
            <div id="branding"><strong><a href="<?php print $front_page ?>" title="<?php print $site_name_and_slogan ?>">
            <?php if ($logo): ?>
              <img src="<?php print $logo ?>" alt="<?php print $site_name_and_slogan ?>" id="logo" />
            <?php endif; ?>
            <?php print $site_html ?>
            </a></strong></div>
          <?php else: /* Use h1 when the content title is empty */ ?>
            <h1 id="branding"><a href="<?php print $front_page ?>" title="<?php print $site_name_and_slogan ?>">
            <?php if ($logo): ?>
              <img src="<?php print $logo ?>" alt="<?php print $site_name_and_slogan ?>" id="logo" />
            <?php endif; ?>
            <?php print $site_html ?>
            </a></h1>
        <?php endif; ?>
        <?php endif; ?>
        </div>

and you'd like to remove the title (so just shortening this line:

            <div id="branding"><strong><a href="<?php print $front_page ?>">

I can't see getting rid of the alt text.

Thoughts? The title does provide some additional information as someone hovers above the image link. It's not completely useless to people.

I've noticed this issue as well. Duplicating the alt attribute of the logo while providing link text could be considered a violation of WCAG 2 2.4.4 (at least that's what a validator I'm using says). Since text for the link is already specified in text, the alt attribute of the image could be null.

Also, Is there a reason why there is white-space after the site name in the title and alt attributes?

Lastly, and probably most important: When site-name is checked off in Garland's theme settings, the link's title and the image's alt attribute are both empty. This is definitely a violation of WCAG 2 1.1.1

#8 - needs a variable_get on the site name etc to make sure the alt is always populated even if theme settings for site name etc are toggled off - we should try to fix this as it is a violation.

Ok, we've got to get a bit closer to a patch here.

We've got the following instances where the $site_name_and_slogan variable is being used:

$ grep -ir site_name_and themes/garland/page.tpl.php 
            <div id="branding"><strong><a href="<?php print $front_page ?>" title="<?php print $site_name_and_slogan ?>">
              <img src="<?php print $logo ?>" alt="<?php print $site_name_and_slogan ?>" id="logo" />
            <h1 id="branding"><a href="<?php print $front_page ?>" title="<?php print $site_name_and_slogan ?>">
              <img src="<?php print $logo ?>" alt="<?php print $site_name_and_slogan ?>" id="logo" />

I'm curious if this isn't also a problem with other themes. They don't seem to use $site_name_and_slogan, but I'm curious how they've avoided this repetition.

@mgifford

Thanks for posting this. It does seem a bit excessive, by which I mean overly verbose.

I don't have a d7 installation at the moment, can you please post the actual generated markup to compare?

This is from my sandbox - http://drupal7.dev.openconcept.ca

<title>OpenConcept Drupal 7 Sandbox | One Sandbox to Rule Them All!</title>

...

                              <h1 id="branding"><a href="/" title="OpenConcept Drupal 7 Sandbox One Sandbox to Rule Them All!">
                          <img src="http://drupal7.dev.openconcept.ca/themes/garland/logo.png" alt="OpenConcept Drupal 7 Sandbox One Sandbox to Rule Them All!" id="logo" />
                        <span>OpenConcept Drupal 7 Sandbox</span> One Sandbox to Rule Them All!            </a></h1>

Not sure how to go around that until there is an option to state the logo's alt text in the theme for D8.

@mgifford

Can we try moving the @title from the anchor to the image? This should still provide the tooltip as desired and would mean (likely) that AT would only read this content twice, once for the image-link and once for the span.

How's this - http://drupal7.dev.openconcept.ca/

                              <h1 id="branding"><a href="/">
                          <img src="http://drupal7.dev.openconcept.ca/themes/garland/logo.png" alt="OpenConcept Drupal 7 Sandbox One Sandbox to Rule Them All!" title="OpenConcept Drupal 7 Sandbox One Sandbox to Rule Them All!" id="logo" />
                        <span>OpenConcept Drupal 7 Sandbox</span> One Sandbox to Rule Them All!            </a></h1>

Tested the sandbox with VoiceOver (SL) / Safari 5.0.1, JAWS 11 and NVDA 2010.1 / Firefox 3.6.9. All performing as expected, name and slogan read once.

Patch looks good setting to RTBC

Well that definitely sounds sub-optimal. :)

Committed to HEAD. Thanks!