Posted by pvasili on May 2, 2010 at 3:12pm
5 followers
Jump to:
| Project: | Google Ad Manager |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Now the module creates one block for each slot.
This is a good idea if very few slots (and blocks).
When the number of slots (blocks) more then 50 - is not a good idea
I want to display in the block slot depending on path.
sample:
[slot1] for path /forum and /forum/*
[slot2] for path /news
...
I can write php code in the block (analyze it) and us [google_ad:ad_slot], but I'll have a lot of unused blocks.
How difficult is it to add this functionality to the module?
Comments
#1
To have this feature, I think, the module should be restructured like this: in admin, user can add block, add adslot. Then in each block, user configures which slots are displayed. The advantages are:
- Allow many slots in a block
- Slots are reusable in different blocks
I will think about this. But now I'd like #765802: Allow loading ads just before </body> to be implemented first, as it could change the way how we put code in blocks.
#2
I'd like this as well. The menu_block module adds a tab to the block config screen where you can add a menu block. It would be nice to be able to ad a Google Admanager block and then in that screen be able to select which ad slots should appear in the block just created.
#3
Suppose better to use 'context' module to choose slot and generate content of block.
#4
Maybe try to use the module http://drupal.org/project/context ?
#5
I was aware of the context module. But I can't imagine how does "n slots in 1 block" fit with context. You may want to be more precise?
#6
An idea was to set block's content depending on rules from context.
#7
You can fit n blocks in 1 block with http://drupal.org/project/bbq
#8
Jax Thanks for your remark. I see there is a problem in the number of blocks only...
#9
It needs a significant structure change in the module. Will consider it in 2.x, when the 1.x branch gets stable.
#10
Since 2.0 is out, I'll take care of this. Any idea is welcome.
Personally I think we can create another entity called "superslot" that displays ad slot depending on context (certain PHP condition). I don't want to make this depend on context.module, because sites that use Panels may feel redundant. Currently, it's easier to do this if you are using Panels (use that "selection rules" for visibility).
#11
Code committed so that you have a basic feature to test. Now you has "superslot" in the settings page, and in blocks page. It needs a few fine tuning, but it currently work.
Incompatible with lazy loading, however. That's why I mark this as "needs work".
#12
The latest commit fixed this problem.
#13
Automatically closed -- issue fixed for 2 weeks with no activity.