evan23 [evan23]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

I will review the code within 6 days from July 4.

subscribing... any update on how this module is going... I could really use it for my e-commerce store as we also use Westpac.

1. The module doesn't implement hook_uninstall() to remove the Drupal variables defined from the module.
2. The code uses strlen() and substr() for strings that could contain Unicode strings (especially if they are gotten from a HTML form).
3. There is commented code that makes me think the code is not complete. You should submit complete code to review it.

4.   require_once drupal_get_path('module', 'uc_payway') .'/api/Qvalent_PayWayAPI.php';
   

   There is a Drupal function that is used to load PHP code from a file.

Reopening as I've been preparing to use this module and would like to see it become a 'proper' Drupal module. I can give some feedback regarding comment 7 and am willing to maintain a Drupal.org version if evan23 is not around/willing to do so:

1. hook_uninstall: Will fix.
2. strlen/substr: Could I get a pointer as to the correct processing to use? I've seen drupal_strlen, but am not sure what to use in place of substr. Is it possible to instead check they're not unicode or convert them from unicode (a credit card name and expiry are all that's involved).
3. The api file is provided by Westpac when they have checked the security of your site. It should not be provided as part of the module, though instructions for installing the file should be in a Readme.

Regards,

Nigel

I would appreciate an active maintainer as I also would like a few fixes done, but this coding is way above my level.
I have posted the module also on http://www.ubercart.org/project/uc_payway because i couldnt find this thread when i downloaded it a while ago.

Few edits;
uc_payway_cert_file_path, uc_payway_ca_file_path,uc_payway_log_dir had to have absolute locations, couldnt find any code to replace location so instead of /sites/[all/default]/modules i had to use /home/username/public_html/sites/...

  $orderAmountCents = number_format((float)$amount * 100, 0, '.', '');
  $orderAmountDollars = number_format((float)$amount;

added the second line and referenced it in:

  // Successful requests will have a summary code = 0
  if ($summaryCode == 0) {
    $message = t('Credit card charged: !amount', array('!amount' => uc_currency_format($orderAmountDollars)))
              .'<br />'. t('PayWay receipt no.: @receipt', array('@receipt' => $receiptNo));

as the admin messages were displaying all cent values submitted as dollar values.

changed:

$description = $responseParameters['response.Text'];

to

$description = $responseParameters['response.text'];

as it wasnt showing up in the admin messages

Current Issue
when a user clicks "back" on the review order page and updates details and resubmits it, it then generates a "Duplicate Transaction" error and wont go past the "review page", would love some help in addressing this issue.

Applying for full git access is different from applying for a CVS account, which is not supported anymore. See http://drupal.org/project/projectapplications.

Hi there, what is the status quo with this solution please?

There's https://github.com/GiantRobot/uc_payway_net now for D7. I should post it as a project proper, had forgotten it existed until afestein reminded me just now!

Setting the comments to read-only.

Please read the following links as this is very important information about CVS applications.

• Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications.
• Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:
  

  This project is not covered by Drupal’s security advisory policy.